Date: Sun, 17 Aug 1997 18:15:54 -0700 From: Julian Elischer <julian@whistle.com> To: Garrett Wollman <wollman@FreeBSD.ORG> Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern kern_synch.c Message-ID: <33F7A24A.FF6D5DF@whistle.com> References: <199708161907.MAA10325@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Garrett Wollman wrote: > > wollman 1997/08/16 12:07:22 PDT > > Modified files: > sys/kern kern_synch.c > Log: > Dejulianize DIAGNOSTIC panic code. The types are wrong; probably there's > a missing dereference. > > Revision Changes Path > 1.35 +6 -4 src/sys/kern/kern_synch.c A word to me would have been appreciated.. A side effect of the test you removed is that it is now dereferencing a pointer that is not tested against being NULL which was one of the reasons for that test. it IS very unlikely that this would occur, however since I am seeing misbehaviour in these linked lists, I wanted to be cautious about what I assume.. (a null pointer here would not be dangerous except for this test and I could imagine it legally happenning. (though it probably doesn't)) I will re-commit a cleaner version (but I will test against NULL.)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?33F7A24A.FF6D5DF>