Date: Mon, 15 Mar 2004 07:41:38 -0800 From: Peter Wemm <peter@wemm.org> To: Takahashi Yoshihiro <nyan@jp.FreeBSD.org> Cc: imp@bsdimp.com Subject: Re: cvs commit: src/sys/i386/include dvcfg.h physio_proc.h src/sys/amd64/include dvcfg.h physio_proc.h src/sys/compat/netbsd dvcfg.h physio_proc.h src/sys/dev/ct bshw_machdep.c ct.c ct_isa.c src/sys/dev/ncv ncr53c500.c ncr53c500_pccard.c ncr53c500hw.h ... Message-ID: <200403150741.38591.peter@wemm.org> In-Reply-To: <20040315.224828.41670431.nyan@jp.FreeBSD.org> References: <20040314.125403.41652080.nyan@jp.FreeBSD.org> <20040315.175959.11208797.imp@bsdimp.com> <20040315.224828.41670431.nyan@jp.FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday 15 March 2004 05:48 am, Takahashi Yoshihiro wrote:
> In article <20040315.175959.11208797.imp@bsdimp.com>
>
> "M. Warner Losh" <imp@bsdimp.com> writes:
> > : sys/dev/<device_name>/ is best. Right now dev/ only has
> > : directories, but I'm not sure what [pseudo] device these should
> > : go with.
> >
> > dev/ic already exists for this purpose. Or at least one similar to
> > it.
>
> No. dev/ic is for chip specific registers, not for common files
> between drivers.
Not to mention that these are stub files.. for example, physio_proc.h
is:
struct physio_proc {
};
static __inline struct physio_proc *
physio_proc_enter(bp)
struct buf *bp;
{
return NULL;
}
static __inline void
physio_proc_leave(pp)
struct physio_proc *pp;
{
}
dvcfg.h is 5 macros and a 2-item struct.
Anyway, I made the mistake of assuming that these were for NetBSD API
compatability. I initially thought that the dvcfg.h file was for
interfacing with NetBSD's config(8) system. But instead it seems they
are for a variant of NetBSD.
I don't really care where they go, as long as it isn't in the MD include
areas (they are not MD!), and not in sys/. My favorites right now are
dev/pc98/* or compat/pc98/*. I would also like sys/device_port.h to
move there too since it is used by the same group of ct/ncv/nsp/stg
drivers.
--
Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com
"All of this is for nothing if we don't go to the stars" - JMS/B5
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200403150741.38591.peter>