Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 18 Mar 2002 13:24:04 -0500 (EST)
From:      John Baldwin <jhb@FreeBSD.org>
To:        Robert Watson <rwatson@FreeBSD.ORG>
Cc:        smp@FreeBSD.ORG, current@FreeBSD.ORG, hitmaster2k@yahoo.com, phk@FreeBSD.ORG, tanimura@r.dl.itc.u-tokyo.ac.jp, Munehiro Matsuda <haro@h4.dion.ne.jp>, Alfred Perlstein <bright@mu.org>
Subject:   Re: -current lock warning...
Message-ID:  <XFMail.20020318132404.jhb@FreeBSD.org>
In-Reply-To: <Pine.NEB.3.96L.1020317120811.965J-100000@fledge.watson.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On 17-Mar-2002 Robert Watson wrote:
> 
> On Sun, 17 Mar 2002, Alfred Perlstein wrote:
> 
>> * Munehiro Matsuda <haro@h4.dion.ne.jp> [020317 06:36] wrote:
>> > 
>> > PS. I got another message that happend when I ^C'ed a buildworld earlier, 
>> > with same kernel. May be it should go to Alfred Perlstein?
>> > 
>> > lock order reversal
>> >  1st 0xc198eec0 pipe mutex @ ../../../kern/sys_pipe.c:779
>> >  2nd 0xc0367fe0 Giant @ ../../../i386/i386/trap.c:716
>> 
>> I think there's a place where the pipe can fault on an address while
>> copying, I'll take a look at this. 
> 
> Are there any assertions that should be in place for copyin/copyout
> requring fault handling?  It sounds like somewhere we need to assert that
> Giant is held...

More correct is that probably no locks other than Giant should be held for
copyin/copyout.

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20020318132404.jhb>