Date: Sun, 21 Dec 2014 09:45:11 -0700 From: Ian Lepore <ian@freebsd.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: Andrew Turner <andrew@FreeBSD.org>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r275961 - head/sys/arm/conf Message-ID: <1419180311.1018.66.camel@freebsd.org> In-Reply-To: <20141221080739.GB27290@FreeBSD.org> References: <201412201815.sBKIFOSq060122@svn.freebsd.org> <20141221080739.GB27290@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 2014-12-21 at 08:07 +0000, Alexey Dokuchaev wrote: > On Sat, Dec 20, 2014 at 06:15:24PM +0000, Andrew Turner wrote: > > Author: andrew > > Date: Sat Dec 20 18:15:23 2014 > > New Revision: 275961 > > URL: https://svnweb.freebsd.org/changeset/base/275961 > > > > Log: > > Clean up to use the standard style of "options \t" and "device\t\t" > > > > options HZ=500 # Scheduling quantum is 2 milliseconds. > > [...] > > -options KDB # Enable kernel debugger support. > > +options KDB # Enable kernel debugger support. > > # For minimum debugger support use KDB_TRACE, for interactive use DDB. > > -#options KDB_TRACE # Print a stack trace for a panic. > > -options DDB # Support DDB. > > +#options KDB_TRACE # Print a stack trace for a panic. > > +options DDB # Support DDB. > > # For full debugger support use this instead: > > -#options GDB # Support remote GDB. > > +#options GDB # Support remote GDB. > > [...] > > It also would be nice if we removed trailing dots in comments one day, > preferreably across all config files we have in the tree. > > ./danfe > Why? I thought our rule about comments is that they're complete sentences, punctuated as such. Of course, I also thought we had a rule that 'device' and 'options' in kernel config is always followed by two spaces then a tab, so that you can comment out lines without ruining the indent, and apparently that's not true either (and I have no idea where I got that notion). -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1419180311.1018.66.camel>