Date: Tue, 05 Apr 2005 01:40:03 -0700 From: Colin Percival <cperciva@freebsd.org> To: Uwe Doering <gemini@geminix.org> Cc: freebsd-security@freebsd.org Subject: Re: FreeBSD Security Advisory FreeBSD-SA-05:02.sendfile Message-ID: <42524EE3.2040102@freebsd.org> In-Reply-To: <425248D8.1040508@geminix.org> References: <200504050009.j35099Zr068123@freefall.freebsd.org> <425248D8.1040508@geminix.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Uwe Doering wrote: > + vnode_pager_setsize(vp, 0); > > I wonder, isn't the variable 'vp' actually supposed to be 'ovp' in the > added line? Technically they are identical. 'ovp' is assigned from > 'vp' once in the variable definition section at the start of the function. > > However, using 'vp' when calling vnode_pager_setsize() looks a little > odd given that anywhere else in this function, including another call to > vnode_pager_setsize(), the variable 'ovp' is used instead of 'vp'. I agree that it looks a bit odd; a few people have pointed this out to us (but none of them before it was committed into the CVS tree). That said, it doesn't seem to matter, so I'm not going to go back and change the patch now. Colin Percival
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?42524EE3.2040102>