Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 4 Jan 2011 17:06:03 +0000 (UTC)
From:      Jung-uk Kim <jkim@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r216965 - head/sys/dev/acpica
Message-ID:  <201101041706.p04H63Xx047422@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: jkim
Date: Tue Jan  4 17:06:03 2011
New Revision: 216965
URL: http://svn.freebsd.org/changeset/base/216965

Log:
  Clarify the previous commit.  AcpiFinishGpe() will not clear GPE for us
  because we set it to edge-trigger.

Modified:
  head/sys/dev/acpica/acpi_ec.c

Modified: head/sys/dev/acpica/acpi_ec.c
==============================================================================
--- head/sys/dev/acpica/acpi_ec.c	Tue Jan  4 16:51:24 2011	(r216964)
+++ head/sys/dev/acpica/acpi_ec.c	Tue Jan  4 17:06:03 2011	(r216965)
@@ -685,10 +685,12 @@ EcGpeQueryHandler(void *Context)
 	device_printf(sc->ec_dev, "evaluation of query method %s failed: %s\n",
 	    qxx, AcpiFormatException(Status));
     }
+
+    /* Reenable runtime GPE if its execution was deferred. */
     if (sci_enqueued) {
 	Status = AcpiFinishGpe(sc->ec_gpehandle, sc->ec_gpebit);
 	if (ACPI_FAILURE(Status))
-	    device_printf(sc->ec_dev, "clearing GPE failed: %s\n",
+	    device_printf(sc->ec_dev, "reenabling runtime GPE failed: %s\n",
 		AcpiFormatException(Status));
     }
 }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201101041706.p04H63Xx047422>