Date: Sat, 23 Jun 2018 09:56:25 -0700 From: Cy Schubert <Cy.Schubert@cschubert.com> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: Eitan Adler <eadler@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r335547 - head/usr.bin/top Message-ID: <201806231656.w5NGuPwm005393@slippy.cwsent.com> In-Reply-To: Message from Alexey Dokuchaev <danfe@FreeBSD.org> of "Sat, 23 Jun 2018 16:16:56 -0000." <20180623161656.GB91517@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20180623161656.GB91517@FreeBSD.org>, Alexey Dokuchaev writes: > On Fri, Jun 22, 2018 at 09:45:18AM +0000, Eitan Adler wrote: > > New Revision: 335547 > > URL: https://svnweb.freebsd.org/changeset/base/335547 > > > > Log: > > top(1): remove special handling of load > 5 > > > > ... > > Modified: head/usr.bin/top/screen.c > > =========================================================================== > === > > --- head/usr.bin/top/screen.c Fri Jun 22 09:41:13 2018 (r33554 > 6) > > +++ head/usr.bin/top/screen.c Fri Jun 22 09:45:18 2018 (r33554 > 7) > > @@ -55,7 +55,7 @@ static struct termios new_settings; > > static char is_a_terminal = false; > > > > void > > -init_termcap(int interactive) > > +init_termcap(bool interactive) > > { > > char *bufptr; > > char *PCptr; > > @@ -138,7 +138,7 @@ init_termcap(int interactive) > > /* get "ce", clear to end */ > > if (!overstrike) > > { > > - clear_line = tgetstr("ce", &bufptr); > > + clear_line = tgetstr("ce", &bufptr); > > } > > (I've seen it before, and replying to this commit as an example): would > you mind separating style and functional changes into different commits? > I know that top(1) is full of style bugs and it's very tempting to fix > them when you see them, but that's not really the best way to go. Agreed. My src commit bit mentor made sure I separated functional from style commits. Having been a prior ports committer, we on the ports side batch commits all the time but when glebius pointed this out to me I understood the reason why and I now try to do the same on the ports side of the fence too. It's more difficult it but IMO well worth it. I find that git helps separate these types of commits -- if I make a mistake it's easy enough to back out a git commit and do it again before git svn dcommit. Just my $0.02. -- Cheers, Cy Schubert <Cy.Schubert@cschubert.com> FreeBSD UNIX: <cy@FreeBSD.org> Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201806231656.w5NGuPwm005393>