Date: Fri, 10 May 2019 22:10:58 +0300 From: Slawa Olhovchenkov <slw@zxy.spb.ru> To: Andrew Gallatin <gallatin@cs.duke.edu> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, kp@freebsd.org Subject: Re: svn commit: r347410 - in head: . sys/amd64/conf sys/arm/conf sys/arm64/conf sys/i386/conf sys/powerpc/conf sys/riscv/conf sys/sparc64/conf Message-ID: <20190510191058.GC65054@zxy.spb.ru> In-Reply-To: <0842eef5-5f1f-c25a-a470-a424c536f1ed@cs.duke.edu> References: <201905092238.x49McFCO015665@repo.freebsd.org> <20190510124458.GB65054@zxy.spb.ru> <0842eef5-5f1f-c25a-a470-a424c536f1ed@cs.duke.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, May 10, 2019 at 11:31:21AM -0400, Andrew Gallatin wrote:
> On 2019-05-10 08:44, Slawa Olhovchenkov wrote:
>
> > pf have ifdef for IPSEC, but don't have support IPSEC_SUPPORT
> > (netpfil/pf/if_pfsync.c).
> >
>
> Thanks for pointing this out. It seems like IPSEC_SUPPORT would work
> for this. I've made a patch, and it compiles and the pf module loads.
> However, I have no knowledge of how to test it. Is this something
> that you use, and which you can test?
I am don't use pf, I am just explore kernel for ame reasson (IPSEC
performance penalty) and see mostly IPSEC code ifdef to
#if defined(IPSEC) || defined(IPSEC_SUPPORT)
and only netpfil/pf/if_pfsync.c ifdef to
#if defined(IPSEC)
> Thanks,
>
> Drew
>
> diff --git a/sys/netpfil/pf/if_pfsync.c b/sys/netpfil/pf/if_pfsync.c
> index 45b1e090f95c..cc06637b862e 100644
> --- a/sys/netpfil/pf/if_pfsync.c
> +++ b/sys/netpfil/pf/if_pfsync.c
> @@ -308,7 +308,7 @@ static void pfsync_bulk_update(void *);
> static void pfsync_bulk_fail(void *);
>
> static void pfsync_detach_ifnet(struct ifnet *);
> -#ifdef IPSEC
> +#ifdef IPSEC_SUPPORT
> static void pfsync_update_net_tdb(struct pfsync_tdb *);
> #endif
> static struct pfsync_bucket *pfsync_get_bucket(struct pfsync_softc *,
> @@ -1228,7 +1228,7 @@ pfsync_in_tdb(struct pfsync_pkt *pkt, struct mbuf *m, int offset, int count)
> {
> int len = count * sizeof(struct pfsync_tdb);
>
> -#if defined(IPSEC)
> +#if defined(IPSEC_SUPPORT)
> struct pfsync_tdb *tp;
> struct mbuf *mp;
> int offp;
> @@ -1249,7 +1249,7 @@ pfsync_in_tdb(struct pfsync_pkt *pkt, struct mbuf *m, int offset, int count)
> return (len);
> }
>
> -#if defined(IPSEC)
> +#if defined(IPSEC_SUPPORT)
> /* Update an in-kernel tdb. Silently fail if no tdb is found. */
> static void
> pfsync_update_net_tdb(struct pfsync_tdb *pt)
> _______________________________________________
> svn-src-all@freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/svn-src-all
> To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190510191058.GC65054>