Date: Tue, 9 Jul 2019 07:48:52 -0700 From: Steve Kargl <sgk@troutmask.apl.washington.edu> To: Niclas Zeising <zeising@freebsd.org> Cc: Hans Petter Selasky <hps@selasky.org>, Ian Lepore <ian@freebsd.org>, freebsd-current@freebsd.org, takawata@freebsd.org Subject: Re: Someone broke USB Message-ID: <20190709144852.GA65885@troutmask.apl.washington.edu> In-Reply-To: <83a114f5-5e59-de31-be35-f579d3a87ca5@freebsd.org> References: <20190708170323.GA59922@troutmask.apl.washington.edu> <ca435fbe-9942-5b02-0ffc-9d6c5962d1e3@selasky.org> <20190708172414.GA60059@troutmask.apl.washington.edu> <20190708173030.GA60139@troutmask.apl.washington.edu> <08ded31d-b159-6400-cf69-ffb711eca66c@selasky.org> <2fbea10e-ae6c-fe77-f1bc-632c361dde07@selasky.org> <20190708200803.GA61032@troutmask.apl.washington.edu> <0c7badb9-ad29-1691-eed9-dc66ef8b581c@selasky.org> <20190709043301.GB63004@troutmask.apl.washington.edu> <83a114f5-5e59-de31-be35-f579d3a87ca5@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jul 09, 2019 at 10:19:55AM +0200, Niclas Zeising wrote: > On 2019-07-09 06:33, Steve Kargl wrote: > > On Mon, Jul 08, 2019 at 10:54:24PM +0200, Hans Petter Selasky wrote: > >> On 2019-07-08 22:08, Steve Kargl wrote: > >>> On Mon, Jul 08, 2019 at 09:08:17PM +0200, Hans Petter Selasky wrote: > >>>> Hi Steve, > >>>> > >>>> Can you revert all prior patches and try this one instead. > >>>> > >>> > >>> With the new patch, none of the USB devices are found. > >>> I'll be away from the laptop for a few hours. > >>> > >> > >> I've put the USB ACPI code into an own module, which is not enabled by > >> default. So USB should be back to normal for now. > >> > >> https://svnweb.freebsd.org/changeset/base/349851 > >> > > > > Thanks! Unfortunately, things have gone left. To update > > /usr/src to get your change, I pulled in some vm changes, > > which break the graphics/drm-legacy-kmod port. > > > Can you report this, including the failure you're seeing, to > x11@freebsd.org or as an issue on the FreeBSDDesktop github? > Thanks! > Regards Mark's patch to deal with the removed vm_page_unhold() has gotten me past that problem. One none hits ===> Building for drm-legacy-kmod-g20190523 ===> drm (all) ===> drm/drm (all) ===> drm/mach64 (all) ===> drm/mga (all) ===> drm/r128 (all) ===> drm/savage (all) ===> drm/sis (all) ===> drm/tdfx (all) ===> drm/via (all) ===> drm2 (all) ===> drm2/drm2 (all) ===> drm2/i915kms (all) cc -O2 -pipe -march=core2 -fno-strict-aliasing -march=core2 -Werror -D_KERNEL -DKLD_MODULE -nostdinc -I. -I/usr/src/sys -I/usr/src/sys/contrib/ck/include -fno-common -fdebug-prefix-map=./machine=/usr/src/sys/i386/include -fdebug-prefix-map=./x86=/usr/src/sys/x86/include -MD -MF.depend.intel_iic.o -MTintel_iic.o -mno-mmx -mno-sse -msoft-float -ffreestanding -fwrapv -fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error-tautological-compare -Wno-error-empty-body -Wno-error-parentheses-equality -Wno-error-unused-function -Wno-error-pointer-sign -Wno-error-shift-negative-value -Wno-address-of-packed-member -mno-aes -mno-avx -std=iso9899:1999 -I/usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-12bd551/drm2/../src/ -c /usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-12bd551/src/dev/drm2/i915/intel_iic.c -o intel_iic.o /usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-12bd551/src/dev/drm2/i915/intel_iic.c:570:2: error: implicit declaration of function 'iicbus_set_nostop' is invalid in C99 [-Werror,-Wimplicit-function-declaration] iicbus_set_nostop(idev, true); ^ /usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-12bd551/src/dev/drm2/i915/intel_iic.c:570:2: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes] 2 errors generated. *** Error code 1 Stop. make[4]: stopped in /usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-12bd551/drm2/i915kms *** Error code 1 Stop. make[3]: stopped in /usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-12bd551/drm2 *** Error code 1 Stop. make[2]: stopped in /usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-12bd551 *** Error code 1 Stop. make[1]: stopped in /usr/ports/graphics/drm-legacy-kmod *** Error code 1 Stop. make: stopped in /usr/ports/graphics/drm-legacy-kmod -- Steve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190709144852.GA65885>