Date: Mon, 06 May 2024 13:17:18 +0200 From: Alexander Leidinger <Alexander@Leidinger.net> To: garyj@gmx.de Cc: Randall Stewart <rrs@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: fce03f85c5bf - main - TCP can be subject to Sack Attacks lets fix this issue. Message-ID: <b6859d25f2243d594ed1b69adaeed878@Leidinger.net> In-Reply-To: <20240506131136.1bcf87f9@ernst.home> References: <202405051310.445DAMEO069675@gitrepo.freebsd.org> <97c2eddd682d7347b0d26c0f042401bb@Leidinger.net> <20240506131136.1bcf87f9@ernst.home>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --=_0476f1244a2466ac6fb366167ea4aae4 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed Am 2024-05-06 13:11, schrieb Gary Jennejohn: > On Mon, 06 May 2024 09:27:31 +0200 > Alexander Leidinger <Alexander@Leidinger.net> wrote: > >> Am 2024-05-05 15:10, schrieb Randall Stewart: >> > diff --git a/sys/netinet/tcp_stacks/sack_filter.c >> > b/sys/netinet/tcp_stacks/sack_filter.c >> > index e82fcee2ffac..fc9ee8454a1e 100644 >> > --- a/sys/netinet/tcp_stacks/sack_filter.c >> > +++ b/sys/netinet/tcp_stacks/sack_filter.c >> >> > #ifndef _KERNEL >> > + >> > +static u_int tcp_fixed_maxseg(const struct tcpcb *tp) >> > +{ >> > + /* Lets pretend their are timestamps on for user space */ >> > + return (tp->t_maxseg - 12); >> > +} >> >> Typo in the comment? >> > > Yes. Should be Let's as a contraction of Let us. As a non-native english speaker I also would change "their" in this place and reword "timestamps on for user space". Bye, Alexander. -- http://www.Leidinger.net Alexander@Leidinger.net: PGP 0x8F31830F9F2772BF http://www.FreeBSD.org netchild@FreeBSD.org : PGP 0x8F31830F9F2772BF --=_0476f1244a2466ac6fb366167ea4aae4 Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc; size=833 Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEER9UlYXp1PSd08nWXEg2wmwP42IYFAmY4vEwACgkQEg2wmwP4 2IYUXw/+Is7SB2fr+ewIsH6MyUSlH2YboWlwXmbJn5yC4npO492x3JJFy1COUXOI 6fbMviyQYHy+FgMhTjfuT2kQwoJI796342K1hnHTHKUqYDFVypko6zZbcBcw2cKX kMSgHcBeinge/FMR69pQQ0jLEQqMhSXfh4Zyod7Dh7spUOjQdROo3lD4cCqVwTZV qc+hodkSkCFZqSdzb7MmNDPZVPKNPQkwhibp68/5U1rwYTfiyY7XD53QOVFPlKsy a89rKur8+aZw55z8UjpnNT8KWQSwsnHxgXmQJ/Ev3g546WmnXc7lNTni+MWg/1qk yT1dwRF6VZGqENbgDPQ1Qgzq3AYzkHnpj3AXUQK51JicH785hUTx9eTo7O7xfONZ 3+XcrZlqWjHIvK9RX4NTcbSY48bY6TwC85lBJAJFbU3NxUQZ4J0xVx8iAkn8XNuG KTZDKq3d/6gCUSOl/dZCwo4S7FIz7BEWHdCv+blZewA9x74MFofOWWlWJubcZfnb JnRWG2sVo7X5WAt5xtqNi18b/uhScXSeb+yQL1GUw8kwqhYTvuxHOsb5D6+2oQdI N9pwz+EKYCIgHBGQ02V3wOSYJB6TE5RXdZM9JfUwxukqYp2IJmdWwIyyI5T7aF2T 3Bwf5Vaunkf2jVFZOrYl8ueEz5pYX7VejsAQ7sbwa6W7A9Qvrrg= =fylh -----END PGP SIGNATURE----- --=_0476f1244a2466ac6fb366167ea4aae4--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?b6859d25f2243d594ed1b69adaeed878>