Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 15 Dec 1995 01:55:36 +1100
From:      Bruce Evans <bde@zeta.org.au>
To:        CVS-committers@freefall.freebsd.org, cvs-sys@freefall.freebsd.org, peter@freefall.freebsd.org
Subject:   Re: cvs commit: src/sys/pci bt9xx.c
Message-ID:  <199512141455.BAA18909@godzilla.zeta.org.au>

next in thread | raw e-mail | index | archive | help
>  Change the generic "btintr" function's name to "bt_intr" - the same as
>  all the other bt_XXX() functions in i386/scsi/bt*.
>  
>  This the important effect of forcing a link error if the user is
>  still using the old "vector btintr" which is dangerously wrong
>  after Justin's updates to the driver.
>  
>  The correct isa vector line for the bt driver is "vector bt_isa_intr".
>  Justin mentioned this in the commit message and updated LINT and
>  GENERIC.  This change is to enforce that.. :-)

I think btintr should have been left as btintr so that old config files
don't need to be changed.  Only config [-n :-] needs to be run.

Can we agree on a naming scheme for drivers?  I'd like all routines in
module xxx to begin with "xxx" (not "xxx_", unless one is used for
functions and the other for variables).

Bruce



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199512141455.BAA18909>