Date: Fri, 15 Apr 2016 09:45:16 -0600 From: Warner Losh <imp@bsdimp.com> To: Ronald Klop <ronald-lists@klop.ws> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, Warner Losh <imp@freebsd.org> Subject: Re: svn commit: r298011 - head/sys/cam/ata Message-ID: <65ACB63B-ACDF-4552-BDA9-40FB028EB0D6@bsdimp.com> In-Reply-To: <op.yfyvn9epkndu52@sjakie.klop.ws> References: <201604142213.u3EMDklN061064@repo.freebsd.org> <op.yfyvn9epkndu52@sjakie.klop.ws>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] A shorter timeout dramatically cuts the length of time that the queue has to be frozen for error recovery. This allows one, in theory, to recover the system more quickly after a drive goes off into the weeds. Warner > On Apr 15, 2016, at 9:23 AM, Ronald Klop <ronald-lists@klop.ws> wrote: > > Hello, > > Out of curiosity, what are these big problems? Broken device or other things (timeouts/triggers/full queues) going on in the kernel? > > Regards, > Ronald. > > > On Fri, 15 Apr 2016 00:13:46 +0200, Warner Losh <imp@freebsd.org> wrote: > >> Author: imp >> Date: Thu Apr 14 22:13:46 2016 >> New Revision: 298011 >> URL: https://svnweb.freebsd.org/changeset/base/298011 >> erLog: >> Add a comment about why the timeout for flush was lowered to 5s. >> >> Modified: >> head/sys/cam/ata/ata_da.c >> >> Modified: head/sys/cam/ata/ata_da.c >> ============================================================================== >> --- head/sys/cam/ata/ata_da.c Thu Apr 14 22:13:44 2016 (r298010) >> +++ head/sys/cam/ata/ata_da.c Thu Apr 14 22:13:46 2016 (r298011) >> @@ -912,6 +912,11 @@ adadump(void *arg, void *virtual, vm_off >> if (softc->flags & ADA_FLAG_CAN_FLUSHCACHE) { >> xpt_setup_ccb(&ccb.ccb_h, periph->path, CAM_PRIORITY_NORMAL); >> + /* >> + * Tell the drive to flush its intenral cache. if we >> + * can't flush in 5s we have big problems. No need to >> + * wait the default 60s to detect problems. >> + */ >> ccb.ccb_h.ccb_state = ADA_CCB_DUMP; >> cam_fill_ataio(&ccb.ataio, >> 0, >> _______________________________________________ >> svn-src-all@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/svn-src-all >> To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJXEQyMAAoJEGwc0Sh9sBEAsbkQANpylhiE/565ZjJsLYFvkH+G 6ZFGLZdWnFwcEltmEEdJU6McL+iX8/PCwwn8P3wL3RxNg+Cvw5Xnx04JMwnJArfI PtXKxqGuyIdMyTXbp6QjQHWhX175J4Lo7T52qQJ0HIjftTYpZiPj+aopWqwsrBmN REZFc3vLQ0VICCm4SmmgkYXsc6djQHzhdEsTC+Xav2IoS8wajny1WTCHQhzqIUTw 3a3/hti15Q725mo1lzwOHzvo2Jgmv1gQyFRORkBQpDd37h5Ies0i/eQ/fijUBxSR VKlgQTj7hYz9W0sLveVV54DUF4KQuIMHE9XEbtf68nSrzgobay6qDo8BCl7atORy ziS6uEqFoB7C0B9oLHbst53btQnm8KoBsJvJm4zBNjXV+CRkkU9hWLB9dEwMhdON IRJx3G7KbgBzq2jKoF8bmZP3d8CgBjonicm/UKyXAuxg6Gjwn0IWKCpnF9WUC+2D AuSaCccPOVZ1AmgvxAstD3wfMrUkQZrUN/Y5fwklWcCXwVNqYo7fqs7OfyRcpDGq AyCgARpUDa7DKooBiu4eQiTJDDAfvusNBFlpbw35ireU1EOQiG8VFXALP9t63/39 5Hr1NXkgGfshYfwn+5J4Wn8KaDpOuL0KZm4wqLqe+lBID0bjrI1M6doGyCooWMOf 4HRueGtR9oXnCw8wjZl4 =nbV/ -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?65ACB63B-ACDF-4552-BDA9-40FB028EB0D6>