Date: Mon, 25 Nov 2013 13:36:15 +0100 From: Dimitry Andric <dim@FreeBSD.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: Glen Barber <gjb@FreeBSD.org>, freebsd-current <freebsd-current@freebsd.org>, peter@freebsd.org Subject: Re: Buildworld broken with WITHOUT_DYNAMICROOT=yes in src.conf Message-ID: <063D36C2-E1D0-449E-A662-0CCA5A9B887E@FreeBSD.org> In-Reply-To: <20131125075110.GL59496@kib.kiev.ua> References: <201311250111.rAP1BuI0009520@pozo.com> <20131125011949.GC1627@glenbarber.us> <20131125012302.GD1627@glenbarber.us> <201311250129.rAP1TJfQ033437@pozo.com> <20131125041724.GA2310@glenbarber.us> <201311250441.rAP4freb002330@pozo.com> <20131125044854.GC2310@glenbarber.us> <20131125075110.GL59496@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_6B476347-C466-46E3-838F-F7C305574CDE
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
charset=us-ascii
On 25 Nov 2013, at 08:51, Konstantin Belousov <kostikbel@gmail.com> wrote:
> On Sun, Nov 24, 2013 at 11:48:54PM -0500, Glen Barber wrote:
...
>> Index: Makefile
>> ===================================================================
>> --- Makefile (revision 258538)
>> +++ Makefile (working copy)
>> @@ -42,6 +42,9 @@
>>
>> DPADD= ${LIBTERMCAP} ${LIBCRYPT}
>> LDADD= -ltermcap -lcrypt
>> +.if ${MK_ICONV} != "no" && ${MK_DYNAMICROOT} != "yes"
>> +LDADD+= -lc_nonshared
>> +.endif
>>
>> LINKS= ${BINDIR}/csh ${BINDIR}/tcsh
>>
>
> No, this is wrong. As is, static linking is broken and the hack above
> only fixes one case.
>
> What is needed is inclusion of the lib/libc_nonshared object files into
> static libc.a. I am not sure how to express this in our build system.
Hi Kostik,
You can add the additional object files to ${STATICOBJS}. These will
only be built for the static and profiled libraries. See for example
gnu/lib/libgcc/Makefile or lib/libc++/Makefile.
-Dimitry
--Apple-Mail=_6B476347-C466-46E3-838F-F7C305574CDE
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename=signature.asc
Content-Type: application/pgp-signature;
name=signature.asc
Content-Description: Message signed with OpenPGP using GPGMail
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.22 (Darwin)
iEYEARECAAYFAlKTREoACgkQsF6jCi4glqOEIgCfZ33y/qfivaOAlC3s3px0qJXx
MsoAnibbBjhrkxVRp/QGFZvI7OBp5+T4
=QfPp
-----END PGP SIGNATURE-----
--Apple-Mail=_6B476347-C466-46E3-838F-F7C305574CDE--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?063D36C2-E1D0-449E-A662-0CCA5A9B887E>