Date: Thu, 24 Oct 2002 16:41:24 -0400 (EDT) From: Robert Watson <rwatson@FreeBSD.org> To: Juli Mallett <jmallett@FreeBSD.org> Cc: Mark Valentine <mark@thuvia.demon.co.uk>, "\"Sam Leffler\"" <sam@errno.com>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/make var.c Message-ID: <Pine.NEB.3.96L.1021024163937.33116D-100000@fledge.watson.org> In-Reply-To: <20021024133909.A85410@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 24 Oct 2002, Juli Mallett wrote:
> * De: Mark Valentine <mark@thuvia.demon.co.uk> [ Data: 2002-10-24 ]
> [ Subjecte: Re: cvs commit: src/usr.bin/make var.c ]
> > > From: sam@errno.com ("Sam Leffler")
> > > Date: Thu 24 Oct, 2002
> > > Subject: Re: cvs commit: src/usr.bin/make var.c
> >
> > > Juli, this breaks make in groff/tmac (looks like the $f var sub is not done
> > > right). Please back it out for now.
> >
> > Looks like Juli transposed var[1] into val[1]... (Just checked the OpenBSD
> > code.)
>
> Thanks for catching that. Really must switch to a better terminal font.
Alternatively, really must do a full buildworld to test changes when
committing changes to make? As someone else who broke the build briefly
in the last day or two, I make no claims as to being perfect, but things
like make are really pretty sensitive. The other class of changes I have
in mind for more thorough review at testing are rtld changes, which we've
seen a lot of recently, not all thoroughly reviewed.
Robert N M Watson FreeBSD Core Team, TrustedBSD Projects
robert@fledge.watson.org Network Associates Laboratories
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.NEB.3.96L.1021024163937.33116D-100000>