Date: Tue, 15 Apr 2003 18:33:48 +0930 From: Greg 'groggy' Lehey <grog@FreeBSD.org> To: Tim Robbins <tjr@FreeBSD.ORG> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/ps keyword.c print.c ps.h Message-ID: <20030415090348.GJ10776@wantadilla.lemis.com> In-Reply-To: <20030415184815.A11784@dilbert.robbins.dropbear.id.au> References: <200304121039.h3CAduH7079324@repoman.freebsd.org> <20030415050607.GF8718@wantadilla.lemis.com> <20030415184815.A11784@dilbert.robbins.dropbear.id.au>
next in thread | previous in thread | raw e-mail | index | archive | help
--Tu8ztk+XgTAiG9Id Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tuesday, 15 April 2003 at 18:48:15 +1000, Tim Robbins wrote: > On Tue, Apr 15, 2003 at 02:36:07PM +0930, Greg 'groggy' Lehey wrote: > >> On Saturday, 12 April 2003 at 3:39:56 -0700, Tim J. Robbins wrote: >>> tjr 2003/04/12 03:39:56 PDT >>> >>> FreeBSD src repository >>> >>> Modified files: >>> bin/ps keyword.c print.c ps.h >>> Log: >>> Display residency and sleep times (re and sl fields) larger than 127 as 127. >>> This is what the manual page says ps should do, and what OpenBSD and NetBSD do. >> >> Why is this a Good Thing? > > Two reasons: it makes the output of "ps -v" less ugly, and it makes the code > consistent with the documentation. "This is the way we've documented it, so this is the way it has to be" :-) > It's a waste of information though. What do you suggest instead? > Dynamically resizing the column width to fit the number would be one > alternative. Yes, I checked the options before I replied. If it's just a matter of column width, I'd suggest going to 999 and replacing larger values with the text ">1K", which is the same width. But maybe dynamic resizing would make more sense. I wonder why the other BSDs do it this way. I can't imagine that it was a very conscious decision. Could it be that at some point the value was never larger (signed char)? Greg -- See complete headers for address and phone numbers --Tu8ztk+XgTAiG9Id Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.0 (FreeBSD) iD8DBQE+m8r0IubykFB6QiMRAjFBAJ9iioN1buCtt/rxsvjJDh4A7K4sqwCeN4xl ExUNjf5wYLK7CMSqNbLd6rU= =bVZu -----END PGP SIGNATURE----- --Tu8ztk+XgTAiG9Id--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030415090348.GJ10776>