Date: Mon, 30 Nov 1998 23:26:26 -0800 (PST) From: Matthew Dillon <dillon@apollo.backplane.com> To: David Greenman <dg@root.com> Cc: freebsd-current@FreeBSD.ORG Subject: Re: D.O.S. attack protection enhancements commit (ICMP_BANDLIM) Message-ID: <199812010726.XAA03791@apollo.backplane.com> References: <199812010714.XAA26714@root.com>
next in thread | previous in thread | raw e-mail | index | archive | help
:> testing of the same patch to our -current tree).
:>
:> The commit I want to commit is just the ICMP_BANDLIM section. I am
:
: The only comment I have at the moment is that the patches need a little
:KNF work. The mixing of indentation amounts within a function is particularly
:annoying and makes the code difficult to read. Indents should be tabs, with
Don't worry about that... I'll clean that up in an official commit.
I'm not keen on 8-character indents, but I try to commit things that follow
the tone of the surrounding source.
:general scheme implemented perhaps inside the ipfw framework would be more
:appropriate. I also generally like to avoid compile time options for things
:like this, but I"m sympathetic for performance reducing enhancements.
:
:-DG
I figure we would make it the default in 6 months to a year, but
we should have it optioned initially so people can play with it
and also because it defaults to enabled when optioned-in, which I
think is important.
-Matt
:
:David Greenman
:Co-founder/Principal Architect, The FreeBSD Project
:
:To Unsubscribe: send mail to majordomo@FreeBSD.org
:with "unsubscribe freebsd-current" in the body of the message
:
Matthew Dillon Engineering, HiWay Technologies, Inc. & BEST Internet
Communications & God knows what else.
<dillon@backplane.com> (Please include original email in any response)
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199812010726.XAA03791>