Date: Fri, 2 May 2003 15:19:01 -0700 (PDT) From: Nate Lawson <nate@root.org> To: Prafulla Deuskar <pdeuskar@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h if_em_hw.cif_em_hw.h if_em_osdep.h Message-ID: <Pine.BSF.4.21.0305021516490.96473-100000@root.org> In-Reply-To: <20030502211722.9366F37B427@hub.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 2 May 2003, Prafulla Deuskar wrote: > Modified files: > sys/dev/em if_em.c if_em.h if_em_hw.c if_em_hw.h > if_em_osdep.h > Log: > - Bus DMA'fy the driver > - Use htole* macros where appropriate so that the driver could work on non-x86 architectures > - Use m_getcl() instead of MGETHDR/MCLGET macros > Submitted by: sam (Sam Leffler) > > Revision Changes Path > 1.23 +428 -235 src/sys/dev/em/if_em.c > 1.14 +30 -1 src/sys/dev/em/if_em.h In if_em.c, there are a huge number of whitespace changes intermixed with the other changes. It would help us review the changes better if you did these in two separate commits (whitespace first). > 1.8 +0 -0 src/sys/dev/em/if_em_hw.c > 1.9 +0 -0 src/sys/dev/em/if_em_hw.h > 1.11 +0 -0 src/sys/dev/em/if_em_osdep.h It's also helpful to only commit files that you are making changes to. Thanks, -Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0305021516490.96473-100000>