Date: Sun, 14 Sep 2014 10:59:27 +0200 From: Hans Petter Selasky <hps@selasky.org> To: Rick Macklem <rmacklem@uoguelph.ca> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Adrian Chadd <adrian@freebsd.org> Subject: Re: svn commit: r271504 - in head/sys: dev/oce dev/vmware/vmxnet3 dev/xen/netfront net netinet ofed/drivers/net/mlx4 Message-ID: <541558EF.2090700@selasky.org> In-Reply-To: <597691144.35887030.1410644742707.JavaMail.root@uoguelph.ca> References: <597691144.35887030.1410644742707.JavaMail.root@uoguelph.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
On 09/13/14 23:45, Rick Macklem wrote: > Hans Petter Selasky wrote: >> On 09/13/14 18:54, Adrian Chadd wrote: >>> Hi, >>> >>> Just for the record: >>> >>> * I'm glad you're tackling the TSO config stuff; >>> * I'm not glad you're trying to pack it into a u_int rather than >>> creating a new structure and adding fields for it. >>> >>> I appreciate that you're trying to rush this in before 10.1, but >>> this >>> is exactly why things shouldn't be rushed in before release >>> deadlines. >>> :) >>> >>> I'd really like to see this be broken out as a structure and the >>> bit >>> shifting games for what really shouldn't be packed into a u_int >>> fixed. >>> Otherwise this is going to be deadweight that has to persist past >>> 11.0. >>> >> >> Hi Adrian, >> >> I can make that change for -current, making the new structure and >> such. >> This change was intended for 10 where there is only one u_int for >> this >> information. Or do you want me to change that in 10 too? >> >> --HPS >> >> >> > Btw, your patch calls sbsndptr() in tcp_output(), which advances > sb_sndptroff and sb_sndptr by the length. > Then it loops around and reduces the length for the case where > there are too many mbufs in the chain. > Right, though this patch would need to understand segment lengths too and not only count them. --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?541558EF.2090700>