Date: Tue, 19 May 2015 15:13:03 -0400 From: Eric van Gyzen <eric@vangyzen.net> To: Luigi Rizzo <rizzo@iet.unipi.it>, current@freebsd.org Subject: Re: pedantic compiler warnings: double semicolons, function to data pointers Message-ID: <555B8B3F.9030702@vangyzen.net> In-Reply-To: <20150519184252.GB66725@onelab2.iet.unipi.it> References: <20150519184252.GB66725@onelab2.iet.unipi.it>
next in thread | previous in thread | raw e-mail | index | archive | help
On 05/19/2015 14:42, Luigi Rizzo wrote: > While trying to compile some of my (kernel) code in different environments, > i noticed a couple of errors that perhaps might be worth fixing > > - extra semicolons. These come either from explicit repetitions in the code > (see the output of a grep at the end of this message), > or sometimes from the epansion of macros such as BITSET_DEFINE() > > > - conversion between function and data pointers. One is in mbuf.h > > m->m_ext.ext_free = m->m_ext.ext_arg1 = m->m_ext.ext_arg2 = NULL; > > > Shuold we care/bother to fix these as we step through them ? I would say yes, since that would reduce the noise in the compiler warning output. I realize the warning could be disabled, but cleaning up the ~50 occurrences [of ;;] seems like the better way. Eric
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?555B8B3F.9030702>