Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 07 Apr 2008 11:30:11 -0700
From:      LI Xin <delphij@delphij.net>
To:        freebsd-arch@freebsd.org
Cc:        delphij@FreeBSD.ORG
Subject:   Re: [src] cvs commit: src/sys/ufs/ufs ufs_gjournal.c
Message-ID:  <47FA6833.8080904@delphij.net>
In-Reply-To: <20080407181250.6733810656C9@hub.freebsd.org>
References:  <20080407181250.6733810656C9@hub.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

[-- Attachment #1 --]
Picking a random commit:

>   FreeBSD src repository
> 
>   Modified files:
>     sys/ufs/ufs          ufs_gjournal.c 
>   Log:
>   Correct function name in panic().
>   
>   Reported by:    kensmith
>   
>   Revision  Changes    Path
>   1.3       +1 -1      src/sys/ufs/ufs/ufs_gjournal.c
> _______________________________________________
> cvs-all@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/cvs-all
> To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
> 
> 
> Index: src/sys/ufs/ufs/ufs_gjournal.c
> diff -u src/sys/ufs/ufs/ufs_gjournal.c:1.2 src/sys/ufs/ufs/ufs_gjournal.c:1.3
> --- src/sys/ufs/ufs/ufs_gjournal.c:1.2	Mon May 28 00:28:15 2007
> +++ src/sys/ufs/ufs/ufs_gjournal.c	Mon Apr  7 18:12:37 2008
> @@ -82,7 +82,7 @@
>  		cgbno = fsbtodb(fs, cgtod(fs, cg));
>  	}
>  	if ((u_int)ino >= fs->fs_ipg * fs->fs_ncg)
> -		panic("ffs_freefile: range: dev = %s, ino = %lu, fs = %s",
> +		panic("ufs_gjournal_modref: range: dev = %s, ino = %lu, fs = %s",
>  		    devtoname(dev), (u_long)ino, fs->fs_fsmnt);
>  	if ((error = bread(devvp, cgbno, (int)fs->fs_cgsize, NOCRED, &bp))) {
>  		brelse(bp);

Is it suitable to use something like __func__ here?  I mean, will the 
usage of __func__ encouraged practice for base/kernel code or not?

Cheers,
-- 
Xin LI <delphij@delphij.net>	http://www.delphij.net/
FreeBSD - The Power to Serve!


[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFH+mgzOfuToMruuMARCmFcAJsEWl5kqDgehV1wWWnbZ1Rdu8smqACfSmvG
/V3tE/pUv/+lUXj51rQge+w=
=8te6
-----END PGP SIGNATURE-----

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?47FA6833.8080904>