Date: Thu, 14 Dec 1995 23:05:48 +0800 (WST) From: Peter Wemm <peter@jhome.DIALix.COM> To: Bruce Evans <bde@zeta.org.au> Cc: CVS-committers@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/pci bt9xx.c Message-ID: <Pine.BSF.3.91.951214230029.3291C-100000@jhome.DIALix.COM> In-Reply-To: <199512141455.BAA18909@godzilla.zeta.org.au>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 15 Dec 1995, Bruce Evans wrote: > > The correct isa vector line for the bt driver is "vector bt_isa_intr". > > Justin mentioned this in the commit message and updated LINT and > > GENERIC. This change is to enforce that.. :-) > > I think btintr should have been left as btintr so that old config files > don't need to be changed. Only config [-n :-] needs to be run. I guess bt_isa_intr(int) could be renamed to btintr(int) now that bt_intr(void *) is out of the way... > Can we agree on a naming scheme for drivers? I'd like all routines in > module xxx to begin with "xxx" (not "xxx_", unless one is used for > functions and the other for variables). It almost looks like there's a mini-convention of having driver "xx"'s devsw entry points called "xxFUNC" and the internal or otherwise referenced entry points called "xx_FUNC". I dont know if that makes sense or not, but I've seen that in a lot of drivers. As for having a convention.. Yeah, why not.. As long as it's the same as mine.... :-) :-) -Peter > Bruce >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.3.91.951214230029.3291C-100000>