Date: Wed, 23 Oct 2013 08:40:27 -0600 From: Warner Losh <imp@bsdimp.com> To: Tijl Coosemans <tijl@FreeBSD.org> Cc: multimedia-list freebsd <freebsd-multimedia@freebsd.org>, William Grzybowski <william88@gmail.com>, freebsd-standards@FreeBSD.org, Jilles Tjoelker <jilles@stack.nl> Subject: Re: VLC 2.1.0 Message-ID: <55D30F7E-4F38-472C-8143-53200D55DFBA@bsdimp.com> In-Reply-To: <20131023121237.51e5a79e@kalimero.tijl.coosemans.org> References: <CAHtVNLONK3hZTUoJoebjtdZbhwK8pA8deO1um191zF5pZowF9A@mail.gmail.com> <20131022152502.61214646@kalimero.tijl.coosemans.org> <CAHtVNLOp%2BXqj%2BEbVsxDsLj4tjsxJkjWLm9G0ze_ND_noYGu_=Q@mail.gmail.com> <20131022174715.59433270@kalimero.tijl.coosemans.org> <20131022212327.GB20055@stack.nl> <20131023121237.51e5a79e@kalimero.tijl.coosemans.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Oct 23, 2013, at 4:12 AM, Tijl Coosemans wrote:
> <pthread_cleanup.patch>
I think this patch is way too complex. We just need a real statement =
before the } in the unorthodox push/pop macros to make them =
syntactically a statement in all contexts... (void)0; does that, as =
does do { ...} while(0); In the cases where it would matter the =
difference between {} and do { } while(0); can't happen with this macro =
because it can't be used in the context of an if statement without {}...
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55D30F7E-4F38-472C-8143-53200D55DFBA>