Date: Tue, 16 Jul 2013 19:02:32 +0400 From: Sergey Kandaurov <pluknet@freebsd.org> To: John Baldwin <jhb@freebsd.org> Cc: svn-src-head@freebsd.org, "Andrey V. Elsukov" <ae@freebsd.org>, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r253367 - in head/sys: i386/i386 mips/mips powerpc/powerpc sparc64/sparc64 Message-ID: <CAE-mSOKdpoMF7qWJ=fpD6WfsK0vs4yJa78zR_ySBLr7QkhPhQw@mail.gmail.com> In-Reply-To: <201307161002.15094.jhb@freebsd.org> References: <201307151540.r6FFewZc049719@svn.freebsd.org> <201307161002.15094.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 16 July 2013 18:02, John Baldwin <jhb@freebsd.org> wrote: > On Monday, July 15, 2013 11:40:58 am Andrey V. Elsukov wrote: >> Author: ae >> Date: Mon Jul 15 15:40:57 2013 >> New Revision: 253367 >> URL: http://svnweb.freebsd.org/changeset/base/253367 >> >> Log: >> Include sys/systm.h after sys/param.h. >> >> Suggested by: pluknet > > Does this fix something? > > The normal style rule IIUC is to put <sys/types.h> or <sys/param.h> first, > and then to sort alphabetically. In addition to the style bug mentioned by Bruce, this also fixes build error on i386. See r252434, r253351 for details. In file included from /src/sys/i386/i386/uio_machdep.c:48: /src/sys/sys/systm.h:190:6: error: conflicting types for 'critical_exit' void critical_exit(void); ^ ./machine/counter.h:172:3: note: previous implicit declaration is here critical_exit(); ^ JFYI. -- wbr, pluknet
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAE-mSOKdpoMF7qWJ=fpD6WfsK0vs4yJa78zR_ySBLr7QkhPhQw>