Date: Tue, 18 Mar 2025 05:02:27 GMT From: Wei Hu <whu@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Subject: git: 64610df59348 - stable/14 - mana: remove redundant doorbell in mana_poll_rx_cq() Message-ID: <202503180502.52I52Rrn089670@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch stable/14 has been updated by whu: URL: https://cgit.FreeBSD.org/src/commit/?id=64610df59348c5f72fcca56b46a4a2909b41c471 commit 64610df59348c5f72fcca56b46a4a2909b41c471 Author: Wei Hu <whu@FreeBSD.org> AuthorDate: 2025-03-14 05:26:45 +0000 Commit: Wei Hu <whu@FreeBSD.org> CommitDate: 2025-03-18 04:53:56 +0000 mana: remove redundant doorbell in mana_poll_rx_cq() With the last commit to refill the rx mbuf in batch, the doorbell in mana_poll_rx_cq() becomes redundant. Remove it to save a few microseconds spent in mmio call. Reported by: NetApp Reviewed by: Tallamraju, Sai Tested by: whu Fixes: 9b8701b8 ("mana: refill the rx mbuf in batch") MFC after: 3 days Sponsored by: Microsoft (cherry picked from commit 47f4137e44b8079c7784604d220a298db07a19a1) --- sys/dev/mana/mana_en.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/sys/dev/mana/mana_en.c b/sys/dev/mana/mana_en.c index 1df5419e6c64..9eeaec11d1b2 100644 --- a/sys/dev/mana/mana_en.c +++ b/sys/dev/mana/mana_en.c @@ -1890,13 +1890,6 @@ mana_poll_rx_cq(struct mana_cq *cq) mana_process_rx_cqe(cq->rxq, cq, &comp[i]); } - if (comp_read > 0) { - struct gdma_context *gc = - cq->rxq->gdma_rq->gdma_dev->gdma_context; - - mana_gd_wq_ring_doorbell(gc, cq->rxq->gdma_rq); - } - tcp_lro_flush_all(&cq->rxq->lro); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202503180502.52I52Rrn089670>