Date: Sun, 5 May 2002 17:53:24 +0400 (MSD) From: Maxim Konovalov <maxim@macomnet.ru> To: Szilveszter Adam <sziszi@bsd.hu> Cc: fenner@FreeBSD.ORG, <freebsd-current@FreeBSD.ORG>, <phk@FreeBSD.ORG> Subject: Re: savecore.c broken now, breaks world Message-ID: <20020505175219.W37175-100000@news1.macomnet.ru> In-Reply-To: <20020505131747.GA534@fonix.adamsfamily.xx>
next in thread | previous in thread | raw e-mail | index | archive | help
On 15:17+0200, May 5, 2002, Szilveszter Adam wrote:
> Hello,
>
> src/sbin/savecore.c has been broken today, with the commit of rev 1.59
> by Bill Fenner.
>
> It appears that a new magic value, KERNELDUMPMAGIC_CLEARED, has been
> introduced but its value never #define-d in (probably)
> src/sys/sys/kerneldump.h. This way, the program does not compile.
>
> There is only so much one can deduce from the code, it is the author who
> should know what was intended here.
>
> This breaks the world.
This patch solves the problem:
Index: sys_sys/kerneldump.h
===================================================================
RCS file: /home/ncvs/src/sys/sys/kerneldump.h,v
retrieving revision 1.3
diff -u -r1.3 kerneldump.h
--- sys_sys/kerneldump.h 3 Apr 2002 07:24:10 -0000 1.3
+++ sys_sys/kerneldump.h 5 May 2002 13:49:04 -0000
@@ -60,6 +60,7 @@
struct kerneldumpheader {
char magic[20];
#define KERNELDUMPMAGIC "FreeBSD Kernel Dump"
+#define KERNELDUMPMAGIC_CLEARED "FreeBSD Cleard Dump"
char architecture[12];
uint32_t version;
#define KERNELDUMPVERSION 1
%%%
--
Maxim Konovalov, MAcomnet, Internet Dept., system engineer
phone: +7 (095) 796-9079, mailto:maxim@macomnet.ru
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020505175219.W37175-100000>