Date: Mon, 17 Oct 2011 00:16:22 +0000 From: "Bjoern A. Zeeb" <bz@FreeBSD.org> To: src-committers@freebsd.org Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r226454 - head/sys/netinet Message-ID: <F7573915-216B-4EEB-9BF2-104DA22ED0B1@FreeBSD.org> In-Reply-To: <201110170005.p9H05VrP086262@svn.freebsd.org> References: <201110170005.p9H05VrP086262@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 17. Oct 2011, at 00:05 , Bjoern A. Zeeb wrote: > Author: bz > Date: Mon Oct 17 00:05:31 2011 > New Revision: 226454 > URL: http://svn.freebsd.org/changeset/base/226454 >=20 > Log: > Add syntactic sugar missed in r226437 and then not added either when = moving > things around in r226448 but desperately needed to always make things > compile successfully. >=20 GENRIC and LINT did not fail failed on it as it expanded to: int tcp_recvspace =3D 1024*64 followed by: #define SYSCTL_VNET_INT(parent, nbr, name, access, ptr, val, descr) = \ SYSCTL_INT(parent, nbr, name, access, ptr, val, descr) =20 =3D> #define SYSCTL_INT(parent, nbr, name, access, ptr, val, descr) = \=20 SYSCTL_ASSERT_TYPE(INT, ptr, parent, name); = \ SYSCTL_OID(parent, nbr, name, = \ CTLTYPE_INT | CTLFLAG_MPSAFE | (access), = \ ptr, val, sysctl_handle_int, "I", descr) and the SYSCTL_ASSERT_TYPE() expanding to nothing in #define SYSCTL_ASSERT_TYPE(type, ptr, parent, name) leaving just the ';' around; so it ended up as: int tcp_recvspace =3D 1024*64 ; and an expanded SYSCTL_OID(...); > MFC after: 1 week >=20 > Modified: > head/sys/netinet/tcp_input.c >=20 > Modified: head/sys/netinet/tcp_input.c > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- head/sys/netinet/tcp_input.c Sun Oct 16 22:24:04 2011 = (r226453) > +++ head/sys/netinet/tcp_input.c Mon Oct 17 00:05:31 2011 = (r226454) > @@ -183,7 +183,7 @@ SYSCTL_VNET_INT(_net_inet_tcp, OID_AUTO, > &VNET_NAME(tcp_insecure_rst), 0, > "Follow the old (insecure) criteria for accepting RST packets"); >=20 > -VNET_DEFINE(int, tcp_recvspace) =3D 1024*64 > +VNET_DEFINE(int, tcp_recvspace) =3D 1024*64; > #define V_tcp_recvspace VNET(tcp_recvspace) > SYSCTL_VNET_INT(_net_inet_tcp, TCPCTL_RECVSPACE, tcp_recvspace, = CTLFLAG_RW, > &VNET_NAME(tcp_recvspace), 0, "Initial receive socket buffer = size"); --=20 Bjoern A. Zeeb You have to have visions! Stop bit received. Insert coin for new address family.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F7573915-216B-4EEB-9BF2-104DA22ED0B1>