Date: Sat, 3 Feb 2007 18:23:45 +0100 From: Antoine Brodin <antoine.brodin@laposte.net> To: Warner Losh <imp@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/usb uipaq.c Message-ID: <20070203182345.c64553e6.antoine.brodin@laposte.net> In-Reply-To: <200702031633.l13GXmGn001131@repoman.freebsd.org> References: <200702031633.l13GXmGn001131@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Warner Losh <imp@FreeBSD.org> wrote: > imp 2007-02-03 16:33:48 UTC > > FreeBSD src repository > > Modified files: > sys/dev/usb uipaq.c > Log: > Fix non-use, but not memory leak, of devinfop. Set the device's > description here. The fix in the PR isn't necessary at all for memory > leaks, but we weren't setting the device description. > > While I'm here, remove some of the obfuscating macros in attach. > > PR: 108719 > > Revision Changes Path > 1.2 +22 -39 src/sys/dev/usb/uipaq.c Hi Warner, devinfop is leaked in the "goto bad;" case isn't it ? Cheers, Antoine
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070203182345.c64553e6.antoine.brodin>