Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 20 Jan 2014 11:32:29 -0500
From:      John Baldwin <jhb@freebsd.org>
To:        Rui Paulo <rpaulo@felyko.com>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Neel Natu <neel@freebsd.org>
Subject:   Re: svn commit: r260898 - head/sys/kern
Message-ID:  <1536225.gsjt6oXMt2@pippin.baldwin.cx>
In-Reply-To: <EA6A69A5-0620-4BF9-9871-268C416D2F58@felyko.com>
References:  <201401200159.s0K1xa5X012123@svn.freebsd.org> <EA6A69A5-0620-4BF9-9871-268C416D2F58@felyko.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sunday 19 January 2014 18:18:03 Rui Paulo wrote:
> On 19 Jan 2014, at 17:59, Neel Natu <neel@FreeBSD.org> wrote:
> > Author: neel
> > Date: Mon Jan 20 01:59:35 2014
> > New Revision: 260898
> > URL: http://svnweb.freebsd.org/changeset/base/260898
> > 
> > Log:
> >  Bump up WITNESS_COUNT from 1024 to 1536 so there are sufficient entries
> >  for
> >  WITNESS to actually work.
> 
> This value should be automatically tuned...

How do you propose to do so?  This is the count of locks initialized before 
witness' own SYSINIT is executed and the array it sizes is allocated 
statically at compile time.  This used to not be a static array, but an
intrusive list embedded in locks themselves, but we decided to shave a
pointer off of each lock that was only used for that and to use a statically 
sized table instead.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1536225.gsjt6oXMt2>