Date: Sat, 19 Jun 2004 09:58:43 +0100 From: Doug Rabson <dfr@nlsystems.com> To: David Schultz <das@FreeBSD.org> Cc: Dag-Erling Sm?rgrav <des@des.no> Subject: Re: cvs commit: src/contrib/pf/pfctl pfctl_parser.c Message-ID: <200406190958.43804.dfr@nlsystems.com> In-Reply-To: <20040619071754.GA73529@VARK.homeunix.com> References: <200406171523.i5HFNpjs011498@repoman.freebsd.org> <20040618143127.GP9228@elvis.mu.org> <20040619071754.GA73529@VARK.homeunix.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Saturday 19 June 2004 08:17, David Schultz wrote: > On Fri, Jun 18, 2004, Maxime Henrion wrote: > > Dag-Erling Sm?rgrav wrote: > > > Max Laier <mlaier@FreeBSD.org> writes: > > > > Log: > > > > Fix printing of u_int64_t with a cast to unsigned long long. > > > > > > The correct fix is to cast it to uintmax_t and print it with %ju. > > > > Using %llu and a cast to (unsigned long long) is as correct as > > using uintmax_t and %ju because the C99 standard says that "long > > long" is at least 64-bit wide. We generally use {u,}intmax_t in > > FreeBSD because it works in more cases, but in that case we can't > > because OpenBSD doesn't have intmax_t. > > /me wonders how much backpedaling we'll wind up doing on the > uintmax_t casts when someone decides to add uint128_t to gcc > and uintmax_t becomes painfully slow on 32-bit arches. ;-) Gcc already has uint128_t. I use it all the time on PS2 and something like it is used on x86 for SSE...
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200406190958.43804.dfr>