Date: Wed, 8 May 2002 14:13:09 -0400 From: Chris Faulhaber <jedgar@fxp.org> To: Kris Kennaway <kris@obsecurity.org> Cc: doc@FreeBSD.org Subject: Committer's guide patch for distfile changes (was: Re: cvs commit: ports/java/bsh distinfo) Message-ID: <20020508181308.GA87923@peitho.fxp.org> In-Reply-To: <20020508104213.A82388@xor.obsecurity.org> References: <200205080923.g489N1u60793@freefall.freebsd.org> <20020508104213.A82388@xor.obsecurity.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Wed, May 08, 2002 at 10:42:13AM -0700, Kris Kennaway wrote:
> On Wed, May 08, 2002 at 02:23:01AM -0700, Ernst de Haan wrote:
> > znerd 2002/05/08 02:23:01 PDT
> >
> > Modified files:
> > java/bsh distinfo
> > Log:
> > Fix bento error (checksum).
>
> Please summarize the diffs in a followup (forced) commit (like you're
> supposed to when you chase checksums).
>
This seems to come up on a weekly basis. I do not see this addressed
in either the Porter's Handbook nor the Committers-Guide so we should
probably put it in 'writing'. A similiar note should probably go into
the Porter's Handbook; however, since committers are directly affected,
I first looked into adding an entry to the Ports-specific FAQ in the
Committer's Guide. The following basically states what is required
when the checksum for a port's distfile changes without a version
change:
(warning, untested patch but the point should be obvious)
Index: en_US.ISO8859-1/articles/committers-guide/article.sgml
===================================================================
RCS file: /home/ncvs/doc/en_US.ISO8859-1/articles/committers-guide/article.sgml,v
retrieving revision 1.113
diff -u -r1.113 article.sgml
--- en_US.ISO8859-1/articles/committers-guide/article.sgml 6 May 2002 19:13:38 -0000 1.113
+++ en_US.ISO8859-1/articles/committers-guide/article.sgml 8 May 2002 18:05:30 -0000
@@ -2247,6 +2247,23 @@
wra(i)th.</para>
</answer>
</qandaentry>
+
+ <qandaentry>
+ <question>
+ <para>What is required procedure for updating checksum for a
+ port's distfile when the file changes without a version
+ change?</para>
+ </question>
+
+ <answer>
+ <para>When the checksum for a port's distfile is updated due
+ to the author updating the file without changing the port's
+ revision, the commit message should include a summary of
+ the relavent diffs between the original and new distfile.
+ This is done to ensure that the distfile has not been
+ corrupted or maliciously altered.</para>
+ </answer>
+ </qandaentry>
</qandadiv>
</qandaset>
</sect1>
--
Chris D. Faulhaber - jedgar@fxp.org - jedgar@FreeBSD.org
--------------------------------------------------------
FreeBSD: The Power To Serve - http://www.FreeBSD.org
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (FreeBSD)
Comment: FreeBSD: The Power To Serve
iD8DBQE82Wq0ObaG4P6BelARArCTAKCgoKohw/EoEq9P7dv5S3WGWTHs4gCfcZri
fzCk66zRzeMhScgCOfRUROg=
=TVaC
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020508181308.GA87923>