Date: Sat, 03 Feb 2007 11:25:38 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: antoine.brodin@laposte.net Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/usb uipaq.c Message-ID: <20070203.112538.-816357461.imp@bsdimp.com> In-Reply-To: <20070203182345.c64553e6.antoine.brodin@laposte.net> References: <200702031633.l13GXmGn001131@repoman.freebsd.org> <20070203182345.c64553e6.antoine.brodin@laposte.net>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <20070203182345.c64553e6.antoine.brodin@laposte.net>
Antoine Brodin <antoine.brodin@laposte.net> writes:
: Warner Losh <imp@FreeBSD.org> wrote:
: > imp 2007-02-03 16:33:48 UTC
: >
: > FreeBSD src repository
: >
: > Modified files:
: > sys/dev/usb uipaq.c
: > Log:
: > Fix non-use, but not memory leak, of devinfop. Set the device's
: > description here. The fix in the PR isn't necessary at all for memory
: > leaks, but we weren't setting the device description.
: >
: > While I'm here, remove some of the obfuscating macros in attach.
: >
: > PR: 108719
: >
: > Revision Changes Path
: > 1.2 +22 -39 src/sys/dev/usb/uipaq.c
:
: Hi Warner,
:
: devinfop is leaked in the "goto bad;" case isn't it ?
oops, you are correct.
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070203.112538.-816357461.imp>