Date: Sat, 5 Jun 2010 17:53:55 -0700 From: Randall Stewart <rrs@lakerest.net> To: Luigi Rizzo <rizzo@iet.unipi.it> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r208857 - head/sys/netinet Message-ID: <3A129572-D7A0-4211-AB71-21C808981C37@lakerest.net> In-Reply-To: <20100606004429.GC56080@onelab2.iet.unipi.it> References: <201006052139.o55LdrBK045695@svn.freebsd.org> <20100606004429.GC56080@onelab2.iet.unipi.it>
next in thread | previous in thread | raw e-mail | index | archive | help
Luigi: We on the SCTP team ;-) have always worked under the constraint of "scrubbing out" with un-ifdef loads of stuff for - Windows - MacOS-X - User-Space Implementation - Panda (translated IOS-XR) Now there is a HUGE amount of cruft that has some ugly ifdef's in it which I was told way back was a no-no.... (I was also told unifdef is your friend ;-D) Anyway.. I would be more than glad to bring back the "full" code if folks would all agree.. it actually makes it a lot easier when you are debugging to have the precise line number instead of working between two worlds ;-) But of course we would have to get agreement from quite a few folks... but I am game ;-) R On Jun 5, 2010, at 5:44 PM, Luigi Rizzo wrote: > On Sat, Jun 05, 2010 at 09:39:53PM +0000, Randall Stewart wrote: >> Author: rrs >> Date: Sat Jun 5 21:39:52 2010 >> New Revision: 208857 >> URL: http://svn.freebsd.org/changeset/base/208857 >> >> Log: >> Purge out a Windows def that somehow slipped >> past the scrubber. > > i wonder if it makes sense to scrub away the code for other OS. > While I understand the rationale, seeing the whole code might have > several advantages: > - understand the constraints that other OS impose; > - learn what APIs are available in other OS; > - teach people how to write portable code; > > cheers > luigi > ------------------------------ Randall Stewart 803-317-4952 (cell)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3A129572-D7A0-4211-AB71-21C808981C37>