Date: Thu, 27 Aug 2015 19:08:21 +0800 From: Tiwei Bie <btw@mail.ustc.edu.cn> To: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> Cc: svn-soc-all@FreeBSD.org Subject: Re: socsvn commit: r290244 - in soc2015/btw/head/sys: net netinet netinet6 Message-ID: <20150827110747.GA68989@dell> In-Reply-To: <2AC0F143-11B1-4793-B309-0D2DE3B6A995@lists.zabbadoz.net> References: <201508270754.t7R7s13d051650@socsvn.freebsd.org> <2AC0F143-11B1-4793-B309-0D2DE3B6A995@lists.zabbadoz.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Aug 27, 2015 at 10:13:38AM +0000, Bjoern A. Zeeb wrote: > > > On 27 Aug 2015, at 07:54 , btw@FreeBSD.org wrote: > > > > Author: btw > > Date: Thu Aug 27 07:54:00 2015 > > New Revision: 290244 > > URL: http://svnweb.FreeBSD.org/socsvn/?view=rev&rev=290244 > > > > Log: > > Replace the printf()s with optional rate limited debugging for RSS. > > > > Modified: > > soc2015/btw/head/sys/net/rss_config.c > > soc2015/btw/head/sys/net/rss_config.h > > soc2015/btw/head/sys/netinet/in_rss.c > > soc2015/btw/head/sys/netinet6/in6_rss.c > > > Ideally you’d add SDT probes for that as well; printfs for debugging is something we should really stop avoiding I think. > Got it! Thank you so much for your suggestions! :-) I also think it is a good idea to use SDT probes. This patch is the draft of this review [1]. I will forward it to adrian@ and gnn@. Best regards, Tiwei Bie [1] https://reviews.freebsd.org/D3471.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150827110747.GA68989>