Date: Mon, 21 Jan 2019 07:01:22 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 232527] bsd.prog.mk includes bsd.nls.mk unconditionally. Message-ID: <bug-232527-227-oPDIXdnU4d@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-232527-227@https.bugs.freebsd.org/bugzilla/> References: <bug-232527-227@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D232527 jarrod@downtools.com.au changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jarrod@downtools.com.au --- Comment #1 from jarrod@downtools.com.au --- With the same options in src.conf, this also appears to affect the building= of some ports under Poudriere as bsd.nls.mk is also blindly included by share/mk/bsd.lib.mk (releng/12.0 r340773 line 440). =3D=3D=3D> Building for libsunacl-1.0.1 make[1]: "/usr/share/mk/bsd.opts.mk" line 101: warning: "NO_PROFILE is defi= ned, but deprecated. Please use MK_PROFILE=3Dno instead." make[1]: "/usr/share/mk/bsd.lib.mk" line 440: Could not find bsd.nls.mk make[1]: Fatal errors encountered -- cannot continue make[1]: stopped in /wrkdirs/usr/ports/sysutils/libsunacl/work/libsunacl-1.= 0.1 *** Error code 1 Stop. make: stopped in /usr/ports/sysutils/libsunacl According to tools/build/mk/OptionalObsoleteFiles.inc (releng/12.0 r338929 = line 6283), which is included by ObsoleteFiles.inc, usr/share/mk/bsd.nls.mk is considered optional (well, assuming my interpretation is correct) when NLS support is disabled therefor is deleted on a "make delete-old". .if ${MK_NLS} =3D=3D no OLD_DIRS+=3Dusr/share/nls/ OLD_DIRS+=3Dusr/share/nls/C OLD_FILES+=3Dusr/share/mk/bsd.nls.mk <-- this one here OLD_FILES+=3Dusr/share/nls/C/ee.cat OLD_DIRS+=3Dusr/share/nls/af_ZA.ISO8859-1 If this is the case, the file cannot be relied upon and should be .sinclude= 'd instead or unmarked as being optional in OptionalObsoleteFiles.inc. Probab= ly the latter is the safer? --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-232527-227-oPDIXdnU4d>