Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 6 Jan 2010 09:40:03 GMT
From:      Roman Bogorodskiy <novel@FreeBSD.org>
To:        freebsd-net@FreeBSD.org
Subject:   Re: kern/142197: [ndis] [patch] ndis is missing media status reporting
Message-ID:  <201001060940.o069e3V8095294@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/142197; it has been noted by GNATS.

From: Roman Bogorodskiy <novel@FreeBSD.org>
To: bug-followup@FreeBSD.org, onemda@gmail.com, rpaulo@FreeBSD.org
Cc:  
Subject: Re: kern/142197: [ndis] [patch] ndis is missing media status
 reporting
Date: Wed, 6 Jan 2010 12:32:42 +0300

 --uAKRQypu60I7Lcqm
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 Hello,
 
 Seems like there's a minor problem with that:
 
 cc1: warnings being treated as errors
 /usr/src/sys/modules/if_ndis/../../dev/if_ndis/if_ndis.c: In function 'ndis=
 _media_status':
 /usr/src/sys/modules/if_ndis/../../dev/if_ndis/if_ndis.c:2252: warning: pas=
 sing argument 4 of 'ndis_get_info' from incompatible pointer type
 *** Error code 1
 
 As ndis_get_info accepts 'int', not 'size_t', so after applying this:
 
 --- if_ndis.c.orig	2010-01-06 12:15:17.000000000 +0300
 +++ if_ndis.c	2010-01-06 12:17:03.000000000 +0300
 @@ -2243,7 +2243,7 @@
  	struct ieee80211vap *vap =3D ifp->if_softc;
  	struct ndis_softc *sc =3D vap->iv_ic->ic_ifp->if_softc;
  	uint32_t txrate;
 -	size_t len;
 +	int len;
 =20
  	if (!NDIS_INITIALIZED(sc))
  		return;
 
 it compiles fine.
 
 Roman Bogorodskiy
 
 --uAKRQypu60I7Lcqm
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.10 (FreeBSD)
 
 iJwEAQECAAYFAktEWLAACgkQgHRbOB2qykYkkQP9HBbpfcBkyEl7eLyZz1Egga8i
 MkkjIWtZLDYzfP4I40n1msmydvWPiiFMpXl7M7I4F9qx4dygWhFeYhTSpyRdpxQx
 aWk9c0exeYae5y+hjfciHZ4yEdJtV8A7yOkAXs4Sgi9hYaomWebkK4svUwbVyQsR
 nlb7YXKsPMnLUxkPtmo=
 =W1Zn
 -----END PGP SIGNATURE-----
 
 --uAKRQypu60I7Lcqm--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201001060940.o069e3V8095294>