Date: Sat, 15 Nov 2014 21:31:25 -0800 From: Garrett Cooper <yaneurabeya@gmail.com> To: Alfred Perlstein <alfred@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Garrett Cooper <ngie@FreeBSD.org> Subject: Re: svn commit: r274573 - head/contrib/netbsd-tests/lib/libpthread Message-ID: <22C52F4A-B9EC-4C32-9D26-474B7EF0CEF2@gmail.com> In-Reply-To: <DB00B2E1-F43A-486C-81EF-A010901E5602@gmail.com> References: <201411160508.sAG58JdG055637@svn.freebsd.org> <546833FE.9060904@freebsd.org> <45B1482F-352E-4874-8A89-1EC225A32E93@gmail.com> <54683508.3030104@freebsd.org> <DB00B2E1-F43A-486C-81EF-A010901E5602@gmail.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Nov 15, 2014, at 21:26, Garrett Cooper <yaneurabeya@gmail.com> wrote: > On Nov 15, 2014, at 21:24, Alfred Perlstein <alfred@freebsd.org> wrote: > >> On 11/15/14, 9:22 PM, Garrett Cooper wrote: >>> On Nov 15, 2014, at 21:19, Alfred Perlstein <alfred@freebsd.org> wrote: >>> >>>> This looks easy enough to fix under _thr_find_thread() in libthread. >>>> >>>> Any interest in fixing it? >>> Yes, if it’s POSIXly correct and doesn’t break everything else. >>> >>>> Might be worth hacking _thr_find_thread() to take an ERRNO to return based on NULL until we chase down all the paths into it just in case EINVAL is a valid ptr. >>> K. Thanks for the hint! >>> >>>> Also, just wondering what happens on other platforms, does it elicit a crash? Ie. is NULL a safe value to pass in on other platforms? >>> I wish I knew what happened on !x86 platforms… I honestly don’t have access to ARM/MIPS/PowerPC, so I can’t say :/. >>> >>> Thanks! >> >> Oh, I meant Linux and Solaris, or even other BSD. > > Ah, good question. pho@ ran some of the tests in contrib/netbsd-tests on Linux/OSX before to do a side-by-side comparison, but I haven’t setup the necessary environment to do that testing [yet]. FWIW, there’s some weirdness with one of the testcases that was never fully integrated in at Isilon where it blocks on a random mutex in libthr… trying to figure out what’s causing it to do that, but this might be related... [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJUaDatAAoJEMZr5QU6S73eZy8IAK9A6R+XfpGWKPSqYT/cjDtp UupQUnew12ZiipVGl5MSDQBfGyl+ns16+JYmg3ZVsm/BY6XkeBhszhcr5ZNzCxxT fV1wLI7adeaEyKSe+R0kgV8NAgrcEHMm3OXk2ourHqtmuudnlBdwmjIUTQU018VS q5Gf+N++b3vftpp1H90nydIWzsusELoGg+OdlqB6JY3nudVhKpaOYT9IRBlKcT3q TGRYWq217sORjJHzgr5v4bljmmsTpFNaluKJKMe90GM3SYRcY4yTPCGM1c5nsEl+ tg4bEGsuRZskvbgEACK1d+lWkp1xPEnwt4BMKRzVJ6Wh5ABc2UY6mOVoVub9R4k= =ITZU -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?22C52F4A-B9EC-4C32-9D26-474B7EF0CEF2>