Date: Mon, 17 Mar 2003 13:07:53 -0800 From: "David O'Brien" <obrien@FreeBSD.org> To: cjclark@alum.mit.edu Cc: current@FreeBSD.org Subject: Re: Create linker.hints at boot Message-ID: <20030317210753.GA35762@dragon.nuxi.com> In-Reply-To: <20030317204319.GA98963@blossom.cjclark.org> References: <20030315000920.GA69495@blossom.cjclark.org> <20030315032742.3AE132A7EA@canning.wemm.org> <20030317082834.GC24317@blossom.cjclark.org> <20030317171112.GA32128@dragon.nuxi.com> <20030317204319.GA98963@blossom.cjclark.org>
index | next in thread | previous in thread | raw e-mail
On Mon, Mar 17, 2003 at 12:43:19PM -0800, Crist J. Clark wrote:
> On Mon, Mar 17, 2003 at 09:11:12AM -0800, David O'Brien wrote:
> > On Mon, Mar 17, 2003 at 12:28:34AM -0800, Crist J. Clark wrote:
> > > +kldxref_start () {
> > > + if [ -z "$kldxref_module_path" ]; then
> > > + MODULE_PATHS=`sysctl -n kern.module_path`
> > > + else
> > > + MODULE_PATHS="$kldxref_module_path"
> > > + fi
> >
> > Please change the logic to positive logic:
> >
> > if [ -n "$kldxref_module_path" ]; then
> > MODULE_PATHS="$kldxref_module_path"
> > else
> > MODULE_PATHS=`sysctl -n kern.module_path`
> > fi
>
> Is there a technical reason for that or is it just a "style" issue?
Style, easier to read out loud, easier to understand w/o having to think.
Just like this is hard to "read". It certainly doesn't do what one reads
out loud: "if not string compaire equal".
if (!strcmp(a,b) {
printf("same\n");
}
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030317210753.GA35762>