Date: Fri, 16 Aug 1996 22:09:11 +1000 From: Bruce Evans <bde@zeta.org.au> To: ache@nagual.ru, peter@freefall.freebsd.org Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/i386/isa syscons.c Message-ID: <199608161209.WAA20660@godzilla.zeta.org.au>
index | next in thread | raw e-mail
>> restore nsccons variable from rev 1.115 that was deleted in rev 1.136 >> during phk's staticize/cleanup commits. pstat needs it, the MAXCONS >> option is not visible anywhere else, and pstat uses it to find the bounds >> of the sccons[MAXCONS] array, which varies. >As I remember, poor nsccons variable was deleted/restored already >2-3 times. Even direct comment about pstat not protect it from removing. >Do we have any better way to protect it? It hasn't been restored before (but was missing until rev.1.115. The delete/restores occurred for almost every serial driver. I think declaring the variables as `static const' is good enough. Comments saying that they are used by pstat become silly if they are ever used by other utilities. Brucehome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199608161209.WAA20660>