Date: Mon, 11 Jan 2021 23:08:59 +0300 From: Vladimir Kondratyev <vladimir@kondratyev.su> To: John Baldwin <jhb@FreeBSD.org>, Vladimir Kondratyev <wulf@FreeBSD.org>, src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 0f0379fa5581 - main - hid: Add recently imported drivers to NOTES Message-ID: <f1627b51-4958-245f-3f4e-0489605f32af@kondratyev.su> In-Reply-To: <fa5604ed-0bde-079f-3433-72f8311e82cd@FreeBSD.org> References: <202101101920.10AJK6rv043957@gitrepo.freebsd.org> <fa5604ed-0bde-079f-3433-72f8311e82cd@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11.01.2021 21:11, John Baldwin wrote: > On 1/10/21 11:20 AM, Vladimir Kondratyev wrote: >> The branch main has been updated by wulf: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=0f0379fa5581c6b89d22bd041f7443581bac616c >> >> commit 0f0379fa5581c6b89d22bd041f7443581bac616c >> Author: Vladimir Kondratyev <wulf@FreeBSD.org> >> AuthorDate: 2021-01-09 12:07:19 +0000 >> Commit: Vladimir Kondratyev <wulf@FreeBSD.org> >> CommitDate: 2021-01-10 19:17:20 +0000 >> >> hid: Add recently imported drivers to NOTES >> >> Reviewed by: hselasky >> Differential revision: https://reviews.freebsd.org/D28060 > > Now that we have entries in NOTES, can we perhaps remove HID_DEBUG > from GENERIC Some part of HID code belonged to USB previously. That is why HID_DEBUG line was inherited from already existing USB_DEBUG in GENERIC. If enabling of USB_DEBUG had no relation to HID, we can delete HID_DEBUG. > along with commented out drivers related to usbhid? Yes we can. I'll add mention about minimal number of devices/options required to enable usbhid reliably to NOTES and delete driver lines from GENERIC. I do not want to delete options USBHID_ENABLED as it is about priority rather than features. May be, it have a sense to change it name to USBHID_DISABLED and enable by default.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?f1627b51-4958-245f-3f4e-0489605f32af>