Date: Tue, 02 Mar 2010 12:42:59 +0000 From: Bruce Simpson <bms@incunabulum.net> To: Roman Divacky <rdivacky@freebsd.org> Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org, John Baldwin <jhb@freebsd.org> Subject: Re: svn commit: r204537 - in projects/clangbsd/contrib/libstdc++: include/ext src Message-ID: <4B8D07D3.6000303@incunabulum.net> In-Reply-To: <20100302082214.GA24947@freebsd.org> References: <201003012130.o21LUB0I022574@svn.freebsd.org> <201003011744.45410.jhb@freebsd.org> <20100302082214.GA24947@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 03/02/10 08:22, Roman Divacky wrote:
> <disclaimer>
> I am not a C++ expert but these changes were suggested by a member
> of C++ committee. ie. I trust them :)
>>> @@ -382,7 +382,7 @@ _GLIBCXX_BEGIN_NAMESPACE(__gnu_cxx)
>>> {
>>> _Rope_RopeLeaf<_CharT, _Alloc>* __l
>>> = (_Rope_RopeLeaf<_CharT, _Alloc>*)this;
>>> - __l->_Rope_RopeLeaf<_CharT, _Alloc>::~_Rope_RopeLeaf();
>>> + __l->template _Rope_RopeLeaf<_CharT, _Alloc>::~_Rope_RopeLeaf();
>>> _L_deallocate(__l, 1);
>>> break;
>>> }
>>>
>> Hmm, this hurts my brain to have 'template ' in the middle of a dereference.
>> I also don't see why it should be needed.
>>
> C++ seems to work this way... it's ugly yes, but correct
>
+1. You do need to qualify the use of templates in situations like this.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4B8D07D3.6000303>