Date: Thu, 19 Jan 2017 22:36:56 -0800 From: Conrad Meyer <cem@freebsd.org> To: Antoine Brodin <antoine@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r312404 - head/usr.bin/sed Message-ID: <CAG6CVpUZL13ujKcOjsDfcgg7wNztRK5OHH7BQADAkN_hD-d2pQ@mail.gmail.com> In-Reply-To: <CAALwa8neni57SPZAo4jW8wKu-Up0-M=weR31WtndzXdW2_jKmQ@mail.gmail.com> References: <201701190801.v0J81ZG9008267@repo.freebsd.org> <CAALwa8neni57SPZAo4jW8wKu-Up0-M=weR31WtndzXdW2_jKmQ@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
On Thu, Jan 19, 2017 at 10:29 PM, Antoine Brodin <antoine@freebsd.org> wrote: > On Thu, Jan 19, 2017 at 9:01 AM, Xin LI <delphij@freebsd.org> wrote: >> Author: delphij >> Date: Thu Jan 19 08:01:35 2017 >> New Revision: 312404 >> URL: https://svnweb.freebsd.org/changeset/base/312404 >> >> Log: >> Use S_ISREG instead of manual & (also it's better to compare the >> result from & and the pattern instead of just assuming it's one bit >> value). >> >> Pointed out by Tianjie Mao <tjmao tjmao com>. >> >> MFC after: 2 weeks >> Differential Revision: https://reviews.freebsd.org/D4827 > > Hi, > > sed -i no longer works on symlinks which breaks lots of ports. > Please revert and request an exp-run. That is clearly the intent of the code in question. It was a bug that it worked before — S_IFLNK and S_IFSOCK just happen to have the S_IFREG bit set. It seems like either such ports should be fixed to dereference the link manually, or the check should be removed entirely. Best, Conradhome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpUZL13ujKcOjsDfcgg7wNztRK5OHH7BQADAkN_hD-d2pQ>