Date: Sun, 27 Jun 2004 21:33:44 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> Cc: FreeBSD current users <current@freebsd.org> Subject: Re: jail getfsstat patches. Message-ID: <20040627193344.GO12007@darkness.comp.waw.pl> In-Reply-To: <Pine.BSF.4.53.0406271830120.89503@e0-0.zab2.int.zabbadoz.net> References: <Pine.BSF.4.21.0406251809530.1679-100000@InterJet.elischer.org> <20040627065932.GH12007@darkness.comp.waw.pl> <20040627101951.GJ12007@darkness.comp.waw.pl> <Pine.BSF.4.53.0406271521050.89503@e0-0.zab2.int.zabbadoz.net> <20040627160959.GL12007@darkness.comp.waw.pl> <Pine.BSF.4.53.0406271706340.89503@e0-0.zab2.int.zabbadoz.net> <20040627174040.GM12007@darkness.comp.waw.pl> <Pine.BSF.4.53.0406271754470.89503@e0-0.zab2.int.zabbadoz.net> <20040627180847.GN12007@darkness.comp.waw.pl> <Pine.BSF.4.53.0406271830120.89503@e0-0.zab2.int.zabbadoz.net>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Sun, Jun 27, 2004 at 06:32:49PM +0000, Bjoern A. Zeeb wrote: +> > It starts from: +> > +> > error = suser(td); +> > if (error) +> > return (error); +> > +> > So I don't think it is needed here, but we can put this there just in +> > case of future changes. +> +> for that and perhaps just for consistency with freebsd4_fhstatfs ? This is not intended in freebsd4_fhstatfs(). It is there only because cvtstatfs() is used also by freebsd4_statfs(), freebsd4_fstatfs() and freebsd4_getfsstat(). Anyway. I updated the patch. -- Pawel Jakub Dawidek http://www.FreeBSD.org pjd@FreeBSD.org http://garage.freebsd.pl FreeBSD committer Am I Evil? Yes, I Am! [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFA3yEYForvXbEpPzQRAh90AJoDvHswWRaKhMCC0AL/Ht8gcMLPDACfbUUK AXmlXSWNirDK/THNgmkdj6s= =5U8I -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040627193344.GO12007>