Date: Wed, 7 Oct 2015 18:39:01 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Warner Losh <imp@bsdimp.com> Cc: Warner Losh <imp@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r288911 - head/share/mk Message-ID: <5615C935.2060204@FreeBSD.org> In-Reply-To: <8D5D1CE5-BC57-464D-9C47-63EFF4C1CF2F@bsdimp.com> References: <201510060418.t964Innu071170@repo.freebsd.org> <56140CAD.8080200@FreeBSD.org> <8D5D1CE5-BC57-464D-9C47-63EFF4C1CF2F@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On 10/6/2015 1:24 PM, Warner Losh wrote: >> With the META_MODE changes, sjg introduced this /etc/src-env.conf file >> that is included from sys.mk early, that can be used for overriding >> things like MAKEOBJDIRPREFIX, enabling META_MODE (it needs to be set >> extremely early for AUTO_OBJ support, among other things). >> >> As far as I can tell, the sys.mk change to include src.conf early was >> done out of convenience. Meaning, we could remove that and just add >> back a .include <src.init.mk> or similar at the top of all src Makefiles. > All src makefiles? Yea, I’d rather hoped to avoid that, though it is easily > scripted. I’d thought of this solution at the time I did the MAKESYSPATH > hack, and rejected it as being too unwieldy. And having that at the top > of all the files would still require MAKESYSPATH need to be …/share/mk > to work out. I was rather hoping we could find some good way around > doing that. r289000 confuses me. Clearly src.opts.mk is still needed in Makefiles. So why are we including src.conf in sys.mk and not src.opts.mk? -- Regards, Bryan Drewery [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJWFck2AAoJEDXXcbtuRpfP3PsIAJfi1TuIRAI+xwKngm1jf2tw H8wD9sp+3cb40joqQyEcDR8pEd5mcnz75WCPOrkNMonG6lSVw+rlK4to2QRTRUMQ ML5eFaj/1PM2sdpLRLZUnNdVHievVZRKzIedxa6KqkZZGgBvT7OGWz5grhPcbT5B qyL+bzLgjAad5tle6zhTM3jHQqfDolEsWn33nOvj9131Eb4Ia7R+k4wNNQ9vVxJ+ XOVARkO2kAphwmMq96ph9KobRPZEfPfP697Jg7hZ2lLKtNxFKf4YNYI2dRIBA6+i cYJkpkjzOsOfSfB6VCjD+fyBdApGU6DwFURkw88WLNhaDhrtWtxk0daCiTxefaI= =5Y83 -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5615C935.2060204>