Date: Sun, 29 Sep 2024 11:53:10 +0200 From: Kristof Provost <kp@freebsd.org> To: Zhenlei Huang <zlei@freebsd.org> Cc: Gary Jennejohn <garyj@gmx.de>, Ian FREISLICH <ianfreislich@gmail.com>, FreeBSD Current <current@freebsd.org> Subject: Re: Is INET6 a required option these days? (kernel build failure) Message-ID: <01A54634-1A79-4B52-96C4-88253725910C@freebsd.org> In-Reply-To: <4E5CBF78-A9AC-4D1C-9D81-CB379C408468@FreeBSD.org> References: <4E5CBF78-A9AC-4D1C-9D81-CB379C408468@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
> On 29 Sep 2024, at 04:46, Zhenlei Huang <zlei@freebsd.org> wrote: > > > >> On Sep 27, 2024, at 6:07 PM, Gary Jennejohn <garyj@gmx.de> wrote: >> >>> On Thu, 26 Sep 2024 14:58:40 -0400 >>> Ian FREISLICH <ianfreislich@gmail.com> wrote: >>> >>> Lately there have been a couple of commits that fail to build because v6 being compiled in despite INET6 being undefined. I think the latest is 905db4aa88775865097714c170f4503da385747c. >>> >>> /usr/src/sys/netpfil/pf/pf.c:8762:38: error: no member named 'icmp6' in 'union pf_headers'; did you mean 'icmp'? >>> 8762 | if (!pf_pull_hdr(m, *off, &pd->hdr.icmp6, icmp_hlen, >>> >>> Ian >>> >> >> This happens now and then because most committers have INET6 enabled and >> they forget that INET6 is an option and not mandatory. > > Kristof is landing lots of commits from upstream ( OpenBSD ), so we need be patient with him ... > There may have been intermittent breakage, although I always try to avoid that, but main currently just works. >> >> I don't have INET6 enabled and have reported a number of problems in the >> source as a result of that. I strongly advise against running non-default configurations. They’re always less tested (and thus more buggy) and harder to support. Only do so if there’s genuinely no alternative. Best regards, Kristofhelp
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?01A54634-1A79-4B52-96C4-88253725910C>