Date: Sat, 8 May 2021 00:22:24 -0500 From: Pedro Giffuni <pfg@FreeBSD.org> To: Randall Stewart <rrs@FreeBSD.org> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: 5a4333a5378f - main - This takes Warners suggested approach to making it so that platforms that for whatever reason cannot include the RATELIMIT option can still work with rack. It adds two dummy functions that rack will call and find out that the highest hw supported b/w is 0 (which kinda makes sense and rack is already prepared to handle). Message-ID: <4b297976-4b06-33a8-b390-18c01561b463@FreeBSD.org> In-Reply-To: <C0E744A2-6069-4334-A82E-F2729E1D7A7B@freebsd.org> References: <202105072134.147LYjPn018824@gitrepo.freebsd.org> <C0E744A2-6069-4334-A82E-F2729E1D7A7B@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 07/05/2021 16:37, Jessica Clarke wrote: > On 7 May 2021, at 22:34, Randall Stewart <rrs@FreeBSD.org> wrote: >> The branch main has been updated by rrs: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=5a4333a5378f7afe4f8cab293a987865ae0c32c4 >> >> commit 5a4333a5378f7afe4f8cab293a987865ae0c32c4 >> Author: Randall Stewart <rrs@FreeBSD.org> >> AuthorDate: 2021-05-07 21:32:32 +0000 >> Commit: Randall Stewart <rrs@FreeBSD.org> >> CommitDate: 2021-05-07 21:32:32 +0000 >> >> This takes Warners suggested approach to making it so that >> platforms that for whatever reason cannot include the RATELIMIT option >> can still work with rack. It adds two dummy functions that rack will >> call and find out that the highest hw supported b/w is 0 (which >> kinda makes sense and rack is already prepared to handle). > Hi Randall, > Could you please start writing a proper separate subject line for your git > commits? This is not best practice, and many tools behave poorly in the > presence of one big paragraph at the start rather than a separate subject line, > including the email hook here. See [1] for FreeBSD’s own guide on the matter. > > Jess > > [1] https://docs.freebsd.org/en/articles/committers-guide/#commit-log-message > +1 even in git this breaks the shortlog in ugly ways.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4b297976-4b06-33a8-b390-18c01561b463>