Date: Fri, 23 Jan 2004 13:07:52 -0800 (PST) From: Robert Watson <rwatson@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/kern kern_prot.c Message-ID: <200401232107.i0NL7qjr006393@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
rwatson 2004/01/23 13:07:52 PST
FreeBSD src repository
Modified files:
sys/kern kern_prot.c
Log:
Don't grab Giant in crfree(), since prison_free() no longer requires it.
The uidinfo code appears to be MPSAFE, and is referenced without Giant
elsewhere. While this grab of Giant was only made in fairly rare
circumstances (actually GC'ing on refcount==0), grabbing Giant here
potentially introduces lock order issues with any locks held by the
caller. So this probably won't help performance much unless you change
credentials a lot in an application, and leave a lot of file descriptors
and cached credentials around. However, it simplifies locking down
consumers of the credential interfaces.
Bumped into by: sam
Appeased: tjr
Revision Changes Path
1.180 +1 -3 src/sys/kern/kern_prot.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200401232107.i0NL7qjr006393>