Date: Sat, 28 Sep 2019 10:35:06 -0600 From: Ian Lepore <ian@freebsd.org> To: Edward Tomasz Napierala <trasz@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r352838 - head/share/man/man3 Message-ID: <d1233433126bb6db32a921c78a2eeb1565d81602.camel@freebsd.org> In-Reply-To: <201909280937.x8S9b5R7060791@repo.freebsd.org> References: <201909280937.x8S9b5R7060791@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 2019-09-28 at 09:37 +0000, Edward Tomasz Napierala wrote: > Author: trasz > Date: Sat Sep 28 09:37:05 2019 > New Revision: 352838 > URL: https://svnweb.freebsd.org/changeset/base/352838 > > Log: > Sort MLINKS for arb(3), and actually make them work by fixing a '=' > vs '+=' > mixup. > ::sigh:: This wouldn't happen if we just always used += for all lines in lists of things, but sadly (IMO, surrealistically), style.Makefile explicitly prohibits that. I'm not sure what value the prohibition is supposed to provide, but the downsides are making this mistake over and over again, and if you manage to avoid the mistake your consolation prize is a diff that's less-clear because you have to change lines that aren't actually involed in the change you're making. -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?d1233433126bb6db32a921c78a2eeb1565d81602.camel>