Date: Mon, 10 Jun 2002 02:14:11 -0500 From: Alan Cox <alc@cs.rice.edu> To: Alfred Perlstein <bright@mu.org> Cc: Alan Cox <alc@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/vm vm_map.c Message-ID: <20020610071411.GL17003@cs.rice.edu> In-Reply-To: <20020610061849.GI88163@elvis.mu.org> References: <200206100611.g5A6BkG16910@freefall.freebsd.org> <20020610061849.GI88163@elvis.mu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jun 09, 2002 at 11:18:49PM -0700, Alfred Perlstein wrote:
> * Alan Cox <alc@FreeBSD.org> [020609 23:12] wrote:
> > alc 2002/06/09 23:11:46 PDT
> >
> > Modified files:
> > sys/vm vm_map.c
> > Log:
> > o In vm_map_entry_create(), call uma_zalloc() with M_NOWAIT on system maps.
> > Submitted by: tegge
>
> Are you sure that is correct? Shouldn't we just propogate the WAIT
> flag down from the higher level allocation rather than _always_
> doing a NOWAIT allocation?
>
Yes, as sure as I (and Tor) can be. Allocation of map entries
for system maps should never be allowed to block. This is not
a new rule. Prior to the UMA conversion, we had:
zinitna(kmapentzone, &kmapentobj,
NULL, 0, cnt.v_page_count / 4, ZONE_INTERRUPT, 1);
^^^^^^^^^^^^^^
Alan
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020610071411.GL17003>