Date: Mon, 30 Jun 2014 16:34:46 -0700 From: Adrian Chadd <adrian@freebsd.org> To: Luigi Rizzo <rizzo@iet.unipi.it> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r268028 - head/sys/dev/e1000 Message-ID: <CAJ-VmomaULvbXcB0WUJOUPUz2beM0rG6Fehq___GfH0WjYYrFQ@mail.gmail.com> In-Reply-To: <20140630150658.GA4742@onelab2.iet.unipi.it> References: <201406300434.s5U4YxGY043870@svn.freebsd.org> <CAJ-Vmom7fsk67Q6sWgwu=GOOn59Zu5uGXeNG%2BYt2hP-edN%2BpvQ@mail.gmail.com> <CA%2BhQ2%2BgOPS6XKeWSNXO2BVkpk%2B82tjvSZ_nWgpwsFgPpEo%2BeNg@mail.gmail.com> <20140630150658.GA4742@onelab2.iet.unipi.it>
next in thread | previous in thread | raw e-mail | index | archive | help
Fixed in both! thanks!
-a
On 30 June 2014 08:06, Luigi Rizzo <rizzo@iet.unipi.it> wrote:
> On Mon, Jun 30, 2014 at 04:56:01PM +0200, Luigi Rizzo wrote:
>> I am getting the following error while compiling with gcc:
>>
>> cc1: warnings being treated as errors
>> /usr/home/luigi/FreeBSD/head/sys/dev/e1000/if_igb.c: In function
>> 'igb_attach':
>> /usr/home/luigi/FreeBSD/head/sys/dev/e1000/if_igb.c:2461: warning: 'cpu_id'
>> may be used uninitialized in this function
>> /usr/home/luigi/FreeBSD/head/sys/dev/e1000/if_igb.c:2461: note: 'cpu_id'
>> was declared here
>>
>> (the code is correct, apparently gcc cannot understand that).
>>
>> For compatibility i'd throw in an explicit initialization,
>> however it might be worthwhile rewriting the code with a single
>> if (adapter->num_queues > 1) { ...} block within the for(),
>> and also using only one #ifdef RSS -- the other places only
>> differ in the string passed to diagnostics or comments.
>
> and the same goes for the recent changes to ixgbe.c
>
> cheers
> luigi
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-VmomaULvbXcB0WUJOUPUz2beM0rG6Fehq___GfH0WjYYrFQ>