Date: Thu, 28 May 2015 19:23:03 -0600 From: Warner Losh <imp@bsdimp.com> To: Tim Kientzle <tim@kientzle.com> Cc: FreeBSD current <freebsd-current@freebsd.org>, freebsd-arm <freebsd-arm@freebsd.org>, Garrett Cooper <yaneurabeya@gmail.com> Subject: Re: am335x-bone.dts not exist Message-ID: <C42FDCFF-676F-40CC-8181-77B63B3DF9AF@bsdimp.com> In-Reply-To: <27DD7AA7-4B66-4A8C-A529-1D67B081326E@kientzle.com> References: <CA%2BK5SrNykSa4n0MykuEQ52nYdh5uXfqsv7=pdAkrW2_1kbDpzQ@mail.gmail.com> <8FF14032-CAAA-41AD-A3A7-DBBAA69D2153@bluezbox.com> <D1360633-5229-4FDF-8098-D585BE7481D2@gmail.com> <B97E9F41-7CCD-4C47-A887-A446EED7456E@bluezbox.com> <4F170567-59B8-477B-8524-D15AF58288C2@kientzle.com> <142808D5-D628-4FCF-BDF4-BBC96D91E118@bsdimp.com> <27DD7AA7-4B66-4A8C-A529-1D67B081326E@kientzle.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] > On May 25, 2015, at 4:19 PM, Tim Kientzle <tim@kientzle.com> wrote: > >> >> On May 25, 2015, at 8:25 AM, Warner Losh <imp@bsdimp.com> wrote: >> >>> >>> On May 24, 2015, at 7:44 PM, Tim Kientzle <tim@kientzle.com> wrote: >>> >>>> >>>> On May 24, 2015, at 12:55 AM, Oleksandr Tymoshenko <gonzo@bluezbox.com> wrote: >>>> >>>> >>>>> On May 24, 2015, at 12:12 AM, Garrett Cooper <yaneurabeya@gmail.com> wrote: >>>>> >>>>> On May 24, 2015, at 0:07, Oleksandr Tymoshenko <gonzo@bluezbox.com> wrote: >>>>> >>>>>>> On May 23, 2015, at 7:21 PM, Andrey Fesenko <f0andrey@gmail.com> wrote: >>>>>>> >>>>>>> # uname -a >>>>>>> FreeBSD des.local 11.0-CURRENT FreeBSD 11.0-CURRENT #0 r283306: Sat >>>>>>> May 23 11:56:46 MSK 2015 >>>>>>> root@des.local:/usr/obj/usr/src/sys/GENERIC amd64 >>>>>>> >>>>>>> I'm build BEAGLEBONE with crochet. >>>>>>> >>>>>>> build error >>>>>>> >>>>>>> Mounting UFS partition 1 at /usr/obj/_.mount.freebsd >>>>>>> Installing U-Boot from : /usr/local/share/u-boot/u-boot-beaglebone >>>>>>> Error: beaglebone.dts:29.1-2 syntax error >>>>>>> FATAL ERROR: Unable to parse input tree >>>>>>> >>>>>>> >>>>>>> file /usr/src/sys/boot/fdt/dts/arm/beaglebone.dts contain #include >>>>>>> "am335x-bone.dts" but this file not existence. Need use am335x-evm.dts >>>>>>> or else? >>>>>> >>>>>> >>>>>> am335x-bone.dts in in sys/gnu/dts/arm/, it's a file provided by vendor (TI) >>>>>> >>>>>> I guess crochet does not have this path as include path when compiling >>>>>> dts files. >>>>> >>>>> Pardon me for being a bit daft potentially, but shouldn’t #include work for all dts files (look for #include in this doc: http://events.linuxfoundation.org/sites/events/files/slides/petazzoni-device-tree-dummies.pdf )? >>>>> Thanks! >>>>> >>>> >>>> >>>> #include in dts file is handled by cpp(1). /include/ is handled >>>> by dtc I believe >>>> >>>> You can take a look at how FreeBSD compiles dts files in >>>> sys/tools/fdt/make_dtb.sh >>>> >>>> crochet does not have cpp stage of compilation and before my TI >>>> code/devicetree refactoring none of the dts files referenced in >>>> crochet used #include. That's why problem never appeared. >>>> >>>> Fix is just a matter of fixing freebsd_install_fdt in lib/freebsd.sh. >>>> If nobody beats me to it I'll try to fix it and submit pull request to Tim. >>> >>> I’m testing a fix for this now. >>> >>> Thanks for providing such detailed information. >> >> Is there any reason the standard dts to dtb script isn’t being used instead of enshrining another copy of that outside the tree which may break if/when we need to enhance the current script? > > Until recently, this didn’t seem necessary; it was a lot simpler to just invoke dtc. I changed things to require cpp when I started merging in the upstream dts files that required it. This was almost a year ago now, about the time we switched back to the GPL dtc because the BSDL one choked on a lot of the newer files. > But times change: https://github.com/freebsd/crochet/commit/22d7555 Cool! Thanks! Warner [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJVZ793AAoJEGwc0Sh9sBEAEWsQAIQApFaKyBqnD2/cNm0DmzG+ UgOxDtHWFD6t8aE2aEdI1eThb2f+VoR4rFh6A0trKDHdUTa0PX6HRwc95OQf+pUW g3oXjY5vbg2xgeLvTFBBbP1lMeXI6Oq7LlbAMDAYI7aI7XWIIFWLCaRl/lSosWav Z/WXkUJg78WdGt7eoTxhUiC/AGXyGrhy6kCHV7BMMXo5TSN7uukMWzyWmPou1Y9t JwWJPD6I/yibsAuJoXnDn74w7quq7qexW2K1cw/atCkkK+lIeF9fqOrzbCxEyUo1 vmluEhHXBTn8TgNN9iuSET7d23UlXo+w/1HEU2faRz1sQhYfS++Ka687/67vQNbA 5rk2HRxeLi7ya+ySUmK4EzJJRVS3lGLu5yahSJRh0x2O99zemOL92q15+2IguujM zoZg9+Lc7nuUx93hNruAqWzoOepDb5J/KZs8hc+akzpdd1Pd76zZ8xyYToBle9bl KvQOtiWw2/PGEywJeIxxknBwUw+UILWTIGUjpfNo/e3+x/fnXYxNwm028igDjAkc uvR+M72tp9zpoo8dpDo718sz9U2LEE3KvBUx5pPbjiqQpp6KbG90CVuEDA/B3Z4f r7uYemPEdfjUCcB4uwK4WyCiVRqXTcFGTLyUvhJs4GItcYEoLYUH18xLh2+k/3W5 zdednss+nO4fD55cpZed =Un28 -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C42FDCFF-676F-40CC-8181-77B63B3DF9AF>